LGTM with tweaks
https://codereview.appspot.com/52610045/diff/1/state/api/common/environwatcher.go File state/api/common/environwatcher.go (right):
https://codereview.appspot.com/52610045/diff/1/state/api/common/environwatcher.go#newcode13 state/api/common/environwatcher.go:13: type EnvironWatcher struct { doc comment
https://codereview.appspot.com/52610045/diff/1/state/api/common/environwatcher.go#newcode14 state/api/common/environwatcher.go:14: name string perhaps facadeName?
https://codereview.appspot.com/52610045/diff/1/state/api/common/environwatcher.go#newcode18 state/api/common/environwatcher.go:18: func NewEnvironWatcher(name string, caller base.Caller) *EnvironWatcher { ditto
https://codereview.appspot.com/52610045/diff/1/state/api/provisioner/provisioner.go File state/api/provisioner/provisioner.go (right):
https://codereview.appspot.com/52610045/diff/1/state/api/provisioner/provisioner.go#newcode16 state/api/provisioner/provisioner.go:16: const Provisioner = "Provisioner" lower case please, no need to export
https://codereview.appspot.com/52610045/
« Back to merge proposal
LGTM with tweaks
https:/ /codereview. appspot. com/52610045/ diff/1/ state/api/ common/ environwatcher. go common/ environwatcher. go (right):
File state/api/
https:/ /codereview. appspot. com/52610045/ diff/1/ state/api/ common/ environwatcher. go#newcode13 common/ environwatcher. go:13: type EnvironWatcher struct {
state/api/
doc comment
https:/ /codereview. appspot. com/52610045/ diff/1/ state/api/ common/ environwatcher. go#newcode14 common/ environwatcher. go:14: name string
state/api/
perhaps facadeName?
https:/ /codereview. appspot. com/52610045/ diff/1/ state/api/ common/ environwatcher. go#newcode18 common/ environwatcher. go:18: func NewEnvironWatch er(name
state/api/
string, caller base.Caller) *EnvironWatcher {
ditto
https:/ /codereview. appspot. com/52610045/ diff/1/ state/api/ provisioner/ provisioner. go provisioner/ provisioner. go (right):
File state/api/
https:/ /codereview. appspot. com/52610045/ diff/1/ state/api/ provisioner/ provisioner. go#newcode16 provisioner/ provisioner. go:16: const Provisioner =
state/api/
"Provisioner"
lower case please, no need to export
https:/ /codereview. appspot. com/52610045/