Code review comment for lp:~thumper/juju-core/cleanup-suite
Revision history for this message
| John A Meinel (jameinel) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
The problem with embedding it in each test, is then you have to update your SetUp and TearDown to call yet-another method, etc. So it is "just one more embed" but that is one more of a bunch of other bits.
This is the sort of thing you would put on a "base" suite if we had such a thing. LoggingSuite comes pretty close. We could rename it for clarity if we like that more.
The failure in the test suite was because the bot rebooted and I missed one line. It should land now. I'm going to mark it Approved because I don't want Tim to have to wait on Bot failure. However, please respond to Roger's comments.