Code review comment for lp:~thumper/juju-core/bootstrap-state-no-constraints-trunk

Reviewers: mp+190851_code.launchpad.net,

Message:
Please take a look.

Description:
Don't pass through empty constraints

If there are no constraints to pass through, cloud init has
   --constraints ''
It seems that somewhere in the process, the empty param is
getting missed and the following --debug param is getting
parsed as a constraint value.

The test is horrible, and all we really care about is the
jujud bootstrap-state line.

https://code.launchpad.net/~thumper/juju-core/bootstrap-state-no-constraints/+merge/190851

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/14494054/

Affected files (+1542, -235 lines):
   A [revision details]
   M charm/repo.go
   M cmd/juju/addmachine.go
   M cmd/juju/addunit.go
   M cmd/juju/bootstrap.go
   M cmd/juju/bootstrap_test.go
   M cmd/juju/cmd_test.go
   M cmd/juju/constraints.go
   M cmd/juju/deploy.go
   M cmd/juju/get.go
   M cmd/juju/help_topics.go
   M cmd/juju/main.go
   M cmd/juju/main_test.go
   M cmd/juju/plugin.go
   M cmd/juju/plugin_test.go
   M cmd/output_test.go
   M cmd/plugins/juju-metadata/metadata.go
   M cmd/plugins/juju-metadata/metadataplugin_test.go
   A cmd/plugins/juju-metadata/signmetadata.go
   A cmd/plugins/juju-metadata/signmetadata_test.go
   M cmd/plugins/juju-metadata/validateimagemetadata.go
   M cmd/plugins/juju-metadata/validateimagemetadata_test.go
   M cmd/plugins/juju-metadata/validatetoolsmetadata.go
   M cmd/plugins/juju-metadata/validatetoolsmetadata_test.go
   M environs/cloudinit/cloudinit.go
   M environs/cloudinit/cloudinit_test.go
   M environs/config/config.go
   M environs/config/config_test.go
   M environs/configstore/disk.go
   M environs/filestorage/filestorage.go
   M environs/httpstorage/backend.go
   M environs/httpstorage/backend_test.go
   A environs/imagemetadata/export_test.go
   M environs/imagemetadata/simplestreams.go
   M environs/imagemetadata/simplestreams_test.go
   M environs/simplestreams/decode.go
   A environs/simplestreams/encode.go
   M environs/simplestreams/export_test.go
   M environs/simplestreams/simplestreams.go
   M environs/simplestreams/simplestreams_test.go
   M environs/simplestreams/testing/testing.go
   M environs/sshstorage/storage.go
   M environs/sshstorage/storage_test.go
   M environs/sync/sync.go
   M environs/sync/sync_test.go
   M environs/tools/export_test.go
   M environs/tools/simplestreams.go
   M environs/tools/simplestreams_test.go
   M juju/osenv/vars_nix.go
   M provider/maas/instance.go
   M provider/maas/instance_test.go
   M provider/openstack/provider.go
   A utils/file_unix.go
   A utils/file_windows.go
   M utils/fslock/fslock.go
   M utils/trivial.go
   A utils/zfile_windows.go
   M version/version.go
   M worker/addressupdater/machine_test.go
   M worker/addressupdater/updater.go
   M worker/uniter/jujuc/relation-get.go
   M worker/uniter/jujuc/relation-get_test.go