Code review comment for lp:~thumper/juju-core/better-local-destroy-environ

The attempt to merge lp:~thumper/juju-core/better-local-destroy-environ into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core 0.019s
ok launchpad.net/juju-core/agent 1.037s
ok launchpad.net/juju-core/agent/mongo 0.607s
ok launchpad.net/juju-core/agent/tools 0.184s
ok launchpad.net/juju-core/bzr 5.184s
ok launchpad.net/juju-core/cert 2.875s
ok launchpad.net/juju-core/charm 0.419s
? launchpad.net/juju-core/charm/hooks [no test files]
? launchpad.net/juju-core/charm/testing [no test files]
ok launchpad.net/juju-core/cloudinit 0.030s
ok launchpad.net/juju-core/cloudinit/sshinit 0.757s
ok launchpad.net/juju-core/cmd 0.164s
ok launchpad.net/juju-core/cmd/charm-admin 0.759s
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 200.061s
ok launchpad.net/juju-core/cmd/jujud 63.958s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 8.824s
? launchpad.net/juju-core/cmd/plugins/juju-restore [no test files]
ok launchpad.net/juju-core/cmd/plugins/local 0.158s
? launchpad.net/juju-core/cmd/plugins/local/juju-local [no test files]
ok launchpad.net/juju-core/constraints 0.026s
ok launchpad.net/juju-core/container 0.052s
ok launchpad.net/juju-core/container/factory 0.046s
ok launchpad.net/juju-core/container/kvm 0.232s
ok launchpad.net/juju-core/container/kvm/mock 0.053s
? launchpad.net/juju-core/container/kvm/testing [no test files]
ok launchpad.net/juju-core/container/lxc 4.316s
? launchpad.net/juju-core/container/lxc/mock [no test files]
? launchpad.net/juju-core/container/lxc/testing [no test files]
? launchpad.net/juju-core/container/testing [no test files]
ok launchpad.net/juju-core/downloader 5.213s
ok launchpad.net/juju-core/environs 2.354s
ok launchpad.net/juju-core/environs/bootstrap 10.152s
ok launchpad.net/juju-core/environs/cloudinit 0.441s
ok launchpad.net/juju-core/environs/config 2.806s
ok launchpad.net/juju-core/environs/configstore 0.036s
ok launchpad.net/juju-core/environs/filestorage 0.026s
ok launchpad.net/juju-core/environs/httpstorage 0.744s
ok launchpad.net/juju-core/environs/imagemetadata 0.433s
? launchpad.net/juju-core/environs/imagemetadata/testing [no test files]
ok launchpad.net/juju-core/environs/instances 0.051s
ok launchpad.net/juju-core/environs/jujutest 0.154s
ok launchpad.net/juju-core/environs/manual 14.050s
ok launchpad.net/juju-core/environs/simplestreams 0.265s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sshstorage 0.880s
ok launchpad.net/juju-core/environs/storage 0.841s
ok launchpad.net/juju-core/environs/sync 43.653s
ok launchpad.net/juju-core/environs/testing 0.171s
ok launchpad.net/juju-core/environs/tools 4.443s
? launchpad.net/juju-core/environs/tools/testing [no test files]
ok launchpad.net/juju-core/errors 0.010s
ok launchpad.net/juju-core/instance 0.018s
? launchpad.net/juju-core/instance/testing [no test files]
ok launchpad.net/juju-core/juju 18.047s
ok launchpad.net/juju-core/juju/arch 0.014s
ok launchpad.net/juju-core/juju/osenv 0.017s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.012s
ok launchpad.net/juju-core/log/syslog 0.039s
? launchpad.net/juju-core/log/syslog/testing [no test files]
ok launchpad.net/juju-core/names 0.027s
? launchpad.net/juju-core/provider [no test files]
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 4.929s
ok launchpad.net/juju-core/provider/common 5.976s
ok launchpad.net/juju-core/provider/dummy 16.684s
ok launchpad.net/juju-core/provider/ec2 15.595s
ok launchpad.net/juju-core/provider/joyent 3.454s
FAIL launchpad.net/juju-core/provider/local [build failed]
ok launchpad.net/juju-core/provider/maas 11.646s
ok launchpad.net/juju-core/provider/manual 1.121s
ok launchpad.net/juju-core/provider/openstack 27.689s
ok launchpad.net/juju-core/replicaset 102.752s
ok launchpad.net/juju-core/rpc 0.081s
ok launchpad.net/juju-core/rpc/jsoncodec 0.027s
? launchpad.net/juju-core/rpc/rpcreflect [no test files]
ok launchpad.net/juju-core/schema 0.019s
ok launchpad.net/juju-core/state 82.049s
ok launchpad.net/juju-core/state/api 1.530s
ok launchpad.net/juju-core/state/api/agent 1.623s
? launchpad.net/juju-core/state/api/base [no test files]
ok launchpad.net/juju-core/state/api/charmrevisionupdater 1.241s
? launchpad.net/juju-core/state/api/common [no test files]
ok launchpad.net/juju-core/state/api/deployer 5.953s
ok launchpad.net/juju-core/state/api/environment 1.669s
ok launchpad.net/juju-core/state/api/firewaller 8.806s
ok launchpad.net/juju-core/state/api/keymanager 3.522s
ok launchpad.net/juju-core/state/api/keyupdater 2.148s
ok launchpad.net/juju-core/state/api/logger 1.864s
ok launchpad.net/juju-core/state/api/machiner 4.446s
ok launchpad.net/juju-core/state/api/params 0.025s
ok launchpad.net/juju-core/state/api/provisioner 9.033s
ok launchpad.net/juju-core/state/api/rsyslog 1.697s
? launchpad.net/juju-core/state/api/testing [no test files]
ok launchpad.net/juju-core/state/api/uniter 25.320s
ok launchpad.net/juju-core/state/api/upgrader 8.198s
ok launchpad.net/juju-core/state/api/usermanager 1.830s
ok launchpad.net/juju-core/state/api/watcher 2.790s
ok launchpad.net/juju-core/state/apiserver 11.358s
ok launchpad.net/juju-core/state/apiserver/agent 2.603s
ok launchpad.net/juju-core/state/apiserver/charmrevisionupdater 2.344s
? launchpad.net/juju-core/state/apiserver/charmrevisionupdater/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/client 41.463s
ok launchpad.net/juju-core/state/apiserver/common 2.252s
? launchpad.net/juju-core/state/apiserver/common/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/deployer 4.023s
ok launchpad.net/juju-core/state/apiserver/environment 1.319s
ok launchpad.net/juju-core/state/apiserver/firewaller 5.414s
ok launchpad.net/juju-core/state/apiserver/keymanager 4.430s
? launchpad.net/juju-core/state/apiserver/keymanager/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/keyupdater 2.633s
ok launchpad.net/juju-core/state/apiserver/logger 3.177s
ok launchpad.net/juju-core/state/apiserver/machine 2.531s
ok launchpad.net/juju-core/state/apiserver/provisioner 9.904s
ok launchpad.net/juju-core/state/apiserver/rsyslog 2.495s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 17.586s
ok launchpad.net/juju-core/state/apiserver/upgrader 9.228s
ok launchpad.net/juju-core/state/apiserver/usermanager 1.748s
ok launchpad.net/juju-core/state/multiwatcher 0.635s
ok launchpad.net/juju-core/state/presence 6.438s
ok launchpad.net/juju-core/state/statecmd 1.567s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 4.825s
ok launchpad.net/juju-core/store 17.320s
ok launchpad.net/juju-core/testing 1.302s
ok launchpad.net/juju-core/testing/testbase 0.014s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.111s
ok launchpad.net/juju-core/tools 0.016s
ok launchpad.net/juju-core/upgrades 6.980s
ok launchpad.net/juju-core/upstart 1.080s
ok launchpad.net/juju-core/utils 2.085s
ok launchpad.net/juju-core/utils/exec 0.029s
ok launchpad.net/juju-core/utils/fslock 0.927s
ok launchpad.net/juju-core/utils/parallel 0.935s
ok launchpad.net/juju-core/utils/set 0.018s
ok launchpad.net/juju-core/utils/shell 0.041s
ok launchpad.net/juju-core/utils/ssh 18.443s
? launchpad.net/juju-core/utils/ssh/testing [no test files]
ok launchpad.net/juju-core/utils/tailer 0.927s
ok launchpad.net/juju-core/utils/voyeur 0.015s
ok launchpad.net/juju-core/utils/zip 0.093s
ok launchpad.net/juju-core/version 0.057s
ok launchpad.net/juju-core/worker 6.434s
ok launchpad.net/juju-core/worker/authenticationworker 2.708s
ok launchpad.net/juju-core/worker/charmrevisionworker 1.869s
ok launchpad.net/juju-core/worker/cleaner 1.093s
ok launchpad.net/juju-core/worker/deployer 3.058s
ok launchpad.net/juju-core/worker/firewaller 8.118s
ok launchpad.net/juju-core/worker/instancepoller 12.122s
ok launchpad.net/juju-core/worker/localstorage 0.046s
ok launchpad.net/juju-core/worker/logger 1.387s
ok launchpad.net/juju-core/worker/machineenvironmentworker 7.282s
ok launchpad.net/juju-core/worker/machiner 2.704s
ok launchpad.net/juju-core/worker/minunitsworker 1.195s
ok launchpad.net/juju-core/worker/peergrouper 1.457s
ok launchpad.net/juju-core/worker/provisioner 37.414s
ok launchpad.net/juju-core/worker/resumer 1.397s
ok launchpad.net/juju-core/worker/rsyslog 3.386s
ok launchpad.net/juju-core/worker/terminationworker 0.047s
ok launchpad.net/juju-core/worker/uniter 103.980s
ok launchpad.net/juju-core/worker/uniter/charm 2.267s
ok launchpad.net/juju-core/worker/uniter/debug 0.095s
ok launchpad.net/juju-core/worker/uniter/hook 0.017s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.377s
ok launchpad.net/juju-core/worker/uniter/relation 1.240s
ok launchpad.net/juju-core/worker/upgrader 3.081s

warning: building out-of-date packages:
 launchpad.net/goamz/ec2/ec2test
 launchpad.net/goamz/s3/s3test
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.

# launchpad.net/juju-core/provider/local_test
provider/local/environ_test.go:15: imported and not used: "launchpad.net/golxc"