Code review comment for lp:~thumper/juju-core/autostart-containers-after-creation

Revision history for this message
Tim Penhey (thumper) wrote :

Please take a look.

https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go
File container/lxc/lxc_test.go (right):

https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go#newcode179
container/lxc/lxc_test.go:179: name := string(instance.Id())
On 2014/03/11 02:24:13, axw wrote:
> It's not clear why this has changed. Has something caused the contents
of the
> file to be different (apart from the lxc.start.auto)? I would think
it's
> preferable to match exactly if it's not too onerous.

Doing an exact match now.

In order to make the match easily, I have also added in the part where
the mounting of the log dir is done after create.

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go
File container/lxc/mock/mock-lxc.go (right):

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go#newcode87
container/lxc/mock/mock-lxc.go:87: data, err :=
ioutil.ReadFile(configFile)
On 2014/03/11 02:24:13, axw wrote:
> There's utils.CopyFile, if you didn't know.

No I didn't. Using it now.

https://codereview.appspot.com/73300043/

« Back to merge proposal