Code review comment for lp:~thumper/juju-core/autostart-containers-after-creation

Revision history for this message
Andrew Wilkins (axwalk) wrote :

https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go
File container/lxc/lxc_test.go (right):

https://codereview.appspot.com/73300043/diff/1/container/lxc/lxc_test.go#newcode179
container/lxc/lxc_test.go:179: name := string(instance.Id())
It's not clear why this has changed. Has something caused the contents
of the file to be different (apart from the lxc.start.auto)? I would
think it's preferable to match exactly if it's not too onerous.

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go
File container/lxc/mock/mock-lxc.go (right):

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go#newcode87
container/lxc/mock/mock-lxc.go:87: data, err :=
ioutil.ReadFile(configFile)
There's utils.CopyFile, if you didn't know.

https://codereview.appspot.com/73300043/diff/1/container/lxc/mock/mock-lxc.go#newcode92
container/lxc/mock/mock-lxc.go:92: return
ioutil.WriteFile(configFilename, data, 0755)
0644?

https://codereview.appspot.com/73300043/

« Back to merge proposal