Code review comment for lp:~thumper/juju-core/autostart-containers-after-creation

Reviewers: mp+210099_code.launchpad.net,

Message:
Please take a look.

Description:
Set lxc autostart after creation.

Currently for a recent LXC version, the autostart is controlled
by a setting in the lxc config. We were setting this in the
config file that we use for creation. However this is not clone
friendly, as we do not specify a config file for clone.

However it is perfectly valid to modify the config for the container
once it has been created. This then becomes common for both
normally created containers and those that have been cloned.

A key here is that our template container that we want to use
as a base to clone off we do not want auto-starting, however
the containers that we clone off that may well want to auto-start
(in fact all will until we add the autostart policy for local).

https://code.launchpad.net/~thumper/juju-core/autostart-containers-after-creation/+merge/210099

Requires:
https://code.launchpad.net/~thumper/juju-core/fast-lxc/+merge/209801

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/73300043/

Affected files (+71, -35 lines):
   A [revision details]
   M container/lxc/export_test.go
   M container/lxc/lxc.go
   M container/lxc/lxc_test.go
   M container/lxc/mock/mock-lxc.go
   M container/lxc/testing/test.go