Code review comment for lp:~thumper/juju-core/agent-tools

Revision history for this message
Tim Penhey (thumper) wrote :

Reviewers: mp+176111_code.launchpad.net,

Message:
Please take a look.

Description:
Make agent/tools and remove state.Tools

This branch makes an agent/tools package that is all things tools.
The environs/tools package is merged in there. There is a test
to ensure that we don't bring in extra package dependencies to
tools, right now just "utils/set" and "version".

https://code.launchpad.net/~thumper/juju-core/agent-tools/+merge/176111

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/11561044/

Affected files:
   A [revision details]
   M agent/agent.go
   M agent/tools/build.go
   M agent/tools/build_test.go
   M agent/tools/diskmanager.go
   M agent/tools/diskmanager_test.go
   M agent/tools/export_test.go
   M agent/tools/list.go
   M agent/tools/list_test.go
   A agent/tools/marshal.go
   A agent/tools/marshal_test.go
   A agent/tools/package_test.go
   M agent/tools/storage.go
   M agent/tools/storage_test.go
   M agent/tools/tools.go
   M agent/tools/tools_test.go
   M agent/tools/toolsdir.go
   D agent/tools_compat_test.go
   M cmd/juju/bootstrap_test.go
   M cmd/juju/status.go
   M cmd/juju/status_test.go
   M cmd/juju/synctools.go
   M cmd/juju/synctools_test.go
   M cmd/juju/upgradejuju.go
   M cmd/juju/upgradejuju_test.go
   M cmd/jujud/agent.go
   M cmd/jujud/agent_test.go
   M cmd/jujud/machine_test.go
   M cmd/jujud/unit_test.go
   M cmd/jujud/upgrade.go
   M cmd/jujud/upgrade_test.go
   M container/lxc/lxc.go
   M container/lxc/lxc_test.go
   M environs/azure/customdata_test.go
   M environs/azure/environ.go
   M environs/cloudinit/cloudinit.go
   M environs/cloudinit/cloudinit_test.go
   M environs/cloudinit_test.go
   M environs/ec2/ec2.go
   M environs/jujutest/livetests.go
   M environs/local/environ.go
   M environs/maas/environ.go
   M environs/maas/environ_test.go
   M environs/openstack/export_test.go
   M environs/openstack/provider.go
   M environs/testing/storage.go
   M environs/testing/tools.go
   M environs/tools.go
   M environs/tools_test.go
   M state/api/params/internal.go
   M state/api/upgrader/upgrader_test.go
   M state/apiserver/upgrader/upgrader.go
   M state/apiserver/upgrader/upgrader_test.go
   M state/machine.go
   M state/machine_test.go
   M state/state.go
   M state/state_test.go
   M state/tools_test.go
   M state/unit.go
   A testing/imports.go
   M worker/deployer/simple.go
   M worker/deployer/simple_test.go
   M worker/provisioner/lxc-broker.go
   M worker/provisioner/lxc-broker_test.go
   M worker/provisioner/provisioner.go
   M worker/uniter/tools_test.go
   M worker/uniter/uniter.go
   M worker/uniter/uniter_test.go

« Back to merge proposal