Please take a look.
https://codereview.appspot.com/13237050/diff/1/agent/format-1.12.go File agent/format-1.12.go (right):
https://codereview.appspot.com/13237050/diff/1/agent/format-1.12.go#newcode19 agent/format-1.12.go:19: const format112 = "format 1.12" On 2013/08/30 07:06:22, fwereade wrote: > 1_12 throughout?
I have renamed "format112" to "format_1_12" because "format1_12" looked too weird.
https://codereview.appspot.com/13237050/diff/1/agent/format-1.12.go#newcode22 agent/format-1.12.go:22: type formatter112 struct { formatter112 becomes formatter_1_12
https://codereview.appspot.com/13237050/diff/1/agent/format-1.12.go#newcode26 agent/format-1.12.go:26: type format112Serialization struct { format112Serialization becomes format_1_12Serialization
https://codereview.appspot.com/13237050/diff/1/agent/format-1.12_whitebox_test.go File agent/format-1.12_whitebox_test.go (right):
https://codereview.appspot.com/13237050/diff/1/agent/format-1.12_whitebox_test.go#newcode6 agent/format-1.12_whitebox_test.go:6: // package. On 2013/08/30 07:06:22, fwereade wrote: > I don't personally feel we need to make a big deal out of this.
Removed then.
https://codereview.appspot.com/13237050/
« Back to merge proposal
Please take a look.
https:/ /codereview. appspot. com/13237050/ diff/1/ agent/format- 1.12.go 1.12.go (right):
File agent/format-
https:/ /codereview. appspot. com/13237050/ diff/1/ agent/format- 1.12.go# newcode19 1.12.go: 19: const format112 = "format 1.12"
agent/format-
On 2013/08/30 07:06:22, fwereade wrote:
> 1_12 throughout?
I have renamed "format112" to "format_1_12" because "format1_12" looked
too weird.
https:/ /codereview. appspot. com/13237050/ diff/1/ agent/format- 1.12.go# newcode22 1.12.go: 22: type formatter112 struct {
agent/format-
formatter112 becomes formatter_1_12
https:/ /codereview. appspot. com/13237050/ diff/1/ agent/format- 1.12.go# newcode26 1.12.go: 26: type format112Serial ization struct { ization becomes format_ 1_12Serializati on
agent/format-
format112Serial
https:/ /codereview. appspot. com/13237050/ diff/1/ agent/format- 1.12_whitebox_ test.go 1.12_whitebox_ test.go (right):
File agent/format-
https:/ /codereview. appspot. com/13237050/ diff/1/ agent/format- 1.12_whitebox_ test.go# newcode6 1.12_whitebox_ test.go: 6: // package.
agent/format-
On 2013/08/30 07:06:22, fwereade wrote:
> I don't personally feel we need to make a big deal out of this.
Removed then.
https:/ /codereview. appspot. com/13237050/