juju-core

Code review comment for lp:~thumper/juju-core/agent-config-formatters

  1. agent-config-formatters
  2. Merge into trunk
Revision history for this message
William Reade (fwereade) wrote :

LGTM, just quibbles

https://codereview.appspot.com/13237050/diff/1/agent/format-1.12.go
File agent/format-1.12.go (right):

https://codereview.appspot.com/13237050/diff/1/agent/format-1.12.go#newcode19
agent/format-1.12.go:19: const format112 = "format 1.12"
1_12 throughout?

https://codereview.appspot.com/13237050/diff/1/agent/format-1.12_whitebox_test.go
File agent/format-1.12_whitebox_test.go (right):

https://codereview.appspot.com/13237050/diff/1/agent/format-1.12_whitebox_test.go#newcode6
agent/format-1.12_whitebox_test.go:6: // package.
I don't personally feel we need to make a big deal out of this.

https://codereview.appspot.com/13237050/

« Back to merge proposal