Code review comment for lp:~thumper/golxc/nicer-destroy

Revision history for this message
John A Meinel (jameinel) wrote :

I'd like to see a test for the:
  return c.Wait(StateRunning, StateStopped)

So that we can make it clear why we need it (a machine that cannot start will transition from starting => stopped, and never show up as "started").

However, I can understand where the overhead of writing a test vs the actual patch doesn't balance well.

review: Approve

« Back to merge proposal