I'm guessing by look at the tests that maybe this is classified wrong in the queue ie this is a work in progress. On running the tests as below, I'm seeing test setup errors for the db tests and a failure due to flake8 missing.
Bundletester is not picking up the unit-tests either (and test_hooks.py is removed from the discovery path). Using a tests.yaml could add "make check" to the tests bt executes (see README https://github.com/juju-solutions/bundletester )
In general the refactor looks good, I might add a simple decorator to encapsulate what is happening in the first few lines of every hook now.
Hi Tim!
I'm guessing by look at the tests that maybe this is classified wrong in the queue ie this is a work in progress. On running the tests as below, I'm seeing test setup errors for the db tests and a failure due to flake8 missing.
''' .juju:/ home/ubuntu/ .juju \ proj/rq/ trusty: /home/ubuntu/ trusty charmbox
docker run -ti --rm --net=host \
-v /home/whit/
-v /home/whit/
workon charm-review
bundletester -vFl DEBUG
'''
https:/ /gist.github. com/whitmo/ 01f5ece4b0e57c5 c2a6b
Bundletester is not picking up the unit-tests either (and test_hooks.py is removed from the discovery path). Using a tests.yaml could add "make check" to the tests bt executes (see README https:/ /github. com/juju- solutions/ bundletester )
In general the refactor looks good, I might add a simple decorator to encapsulate what is happening in the first few lines of every hook now.