Code review comment for lp:~thumper/charms/trusty/python-django/support-1.7

Revision history for this message
Whit Morriss (whitmo) wrote :

Hi Tim!

I'm guessing by look at the tests that maybe this is classified wrong in the queue ie this is a work in progress. On running the tests as below, I'm seeing test setup errors for the db tests and a failure due to flake8 missing.

'''
docker run -ti --rm --net=host \
   -v /home/whit/.juju:/home/ubuntu/.juju \
   -v /home/whit/proj/rq/trusty:/home/ubuntu/trusty charmbox
workon charm-review
bundletester -vFl DEBUG
'''

https://gist.github.com/whitmo/01f5ece4b0e57c5c2a6b

Bundletester is not picking up the unit-tests either (and test_hooks.py is removed from the discovery path). Using a tests.yaml could add "make check" to the tests bt executes (see README https://github.com/juju-solutions/bundletester )

In general the refactor looks good, I might add a simple decorator to encapsulate what is happening in the first few lines of every hook now.

review: Needs Fixing

« Back to merge proposal