Code review comment for lp:~thomnico/charms/precise/elasticsearch/canonical-se

Nicolas,

Thanks for your change submission. I do agree that this is much cleaner. However I see an issue with a user upgrading from revision 28 to this revision: since there is no upgrade-charm logic to handle the change in the location of the service, config, and possibly data files, a user attempting to upgrade this charm could end up in a state of conflict. Unfortunately, I can't give my +1 for this change unless an upgrade-charm hook is added to handle this.

Additionally, I believe there is an Ansible-based charm also being reviewed, which would be another route for cleaning up the elasticsearch charm. Please take a look at the discussion on https://bugs.launchpad.net/charms/+bug/822979 regarding the charm at https://code.launchpad.net/~michael.nelson/charms/precise/elasticsearch/trunk to see if you might prefer to use your efforts to help with that.