Merge lp:~thomnico/charms/precise/dns/openport53 into lp:~lazypower/charms/precise/dns/trunk

[Nicolas Thomas]

[Charles Butler (lazypower)]

Hey Nicolas,

Thanks for the MP. One thing - Im actually tracking upstream development in GitHub here: https://github.com/chuckbutler/dns-charm

Ill be happy to merge this and backport it to HEAD. but in the future if you could target the merges there it would be a big help with my workflow.

Thanks a bunch for the contribution!

review: Approve

[Charles Butler (lazypower)]

Ive merged this on github

https://github.com/chuckbutler/DNS-Charm/commit/2e9aff554960ca669f17e050bba6002c37906157

and will tag + release this with the next round of features. Thanks again Nicolas!

[Nicolas Thomas (thomnico)]

Hi Charles,

Will go on github from now .. no issue .. I just get lost on which is
priming versus chamrstore per project .. sorry...

Is the github to charmstore process automated for this ?? many stuff will
benefit from that

On Wed, Jun 10, 2015 at 1:14 AM, Charles Butler <
<email address hidden>> wrote:

> The proposal to merge lp:~thomnico/charms/precise/dns/openport53 into
> lp:~lazypower/charms/precise/dns/trunk has been updated.
>
> Status: Needs review => Approved
>
> For more details, see:
>
> https://code.launchpad.net/~thomnico/charms/precise/dns/openport53/+merge/261493
> --
> You are the owner of lp:~thomnico/charms/precise/dns/openport53.
>

--
Best Regards,
       Nicolas Thomas
http://insights.ubuntu.com/?p=889
EMEA Solution Architect Canonical
GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

[Charles Butler (lazypower)]

Not yet, but it will be in the future. juju charm publish will allow you to publish an arbitrary bin/tar of your charm code, so it gets decoupled from VCS.

[Nicolas Thomas (thomnico)]

Can you be so kind to push it to charm store ?? I see code in git but
juju deploy dns
get the old one and I can not connect to my real life dns with it, thanks

On Wed, Jun 10, 2015 at 8:34 PM, Charles Butler
<email address hidden> wrote:
> Not yet, but it will be in the future. juju charm publish will allow you to publish an arbitrary bin/tar of your charm code, so it gets decoupled from VCS.
>
>
> --
> https://code.launchpad.net/~thomnico/charms/precise/dns/openport53/+merge/261493
> You are the owner of lp:~thomnico/charms/precise/dns/openport53.

--
Best Regards,
       Nicolas Thomas
http://insights.ubuntu.com/?p=889
EMEA Solution Architect Canonical
GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

Unmerged revisions

13. By Nicolas Thomas on 2015-06-09

Open port 53 in udp to allow connecting to upstream/real dns service.

modified:
  contrib/bind/install.py

=== modified file 'contrib/bind/install.py'
--- contrib/bind/install.py	2014-07-07 12:10:07 +0000
+++ contrib/bind/install.py	2015-06-09 12:31:47 +0000
@@ -37,4 +37,6 @@
             pip_install('files/bind/pip')
 
         os.makedirs('/etc/bind/zone-backup')
-        open_port(53)
+        open_port(53,"TCP")
+        open_port(53,"UDP")
+