Merge lp:~thomir-deactivatedaccount/tanuki-continuous-deployer/trunk-enable-tcp into lp:tanuki-continuous-deployer

Proposed by Thomi Richards
Status: Merged
Approved by: Thomi Richards
Approved revision: 18
Merged at revision: 18
Proposed branch: lp:~thomir-deactivatedaccount/tanuki-continuous-deployer/trunk-enable-tcp
Merge into: lp:tanuki-continuous-deployer
Diff against target: 23 lines (+2/-4)
1 file modified
cd.py (+2/-4)
To merge this branch: bzr merge lp:~thomir-deactivatedaccount/tanuki-continuous-deployer/trunk-enable-tcp
Reviewer Review Type Date Requested Status
Evan (community) Approve
Review via email: mp+269817@code.launchpad.net

Commit message

Enable TCP logstash delivery, and add the deployment info dict in messages again.

Description of the change

Enable TCP logstash delivery, and add the deployment info dict in messages again.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

Yup, we discussed this in email and agreed that TCP for just CD is the way to go.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cd.py'
--- cd.py 2015-09-01 02:29:28 +0000
+++ cd.py 2015-09-01 22:36:18 +0000
@@ -70,7 +70,7 @@
7070
71 # Thomi - 2015-09-01: set this to True (and delete this comment) once we71 # Thomi - 2015-09-01: set this to True (and delete this comment) once we
72 # know that TCP/IP based logstash works well.72 # know that TCP/IP based logstash works well.
73 logger = setup_logger(use_tcp=False)73 logger = setup_logger(use_tcp=True)
7474
75 # Deploy new environment if the stage identifier isn't recorded.75 # Deploy new environment if the stage identifier isn't recorded.
76 idenfifier_dir = os.path.expanduser('~/ci-cd-identifiers/')76 idenfifier_dir = os.path.expanduser('~/ci-cd-identifiers/')
@@ -123,9 +123,7 @@
123 'deployment_name': os.path.dirname(args.stage),123 'deployment_name': os.path.dirname(args.stage),
124 'deployment_identifier': identifier,124 'deployment_identifier': identifier,
125 'mojo_log_path': mojo_log_path,125 'mojo_log_path': mojo_log_path,
126 # XXX cprov 20150820: temporarily avoiding serialization/size issues126 'deployment_info': info,
127 # in Logstash, python-logstash needs to be more robust.
128 #'deployment_info': info,
129 }127 }
130 announcer = logger.info128 announcer = logger.info
131 if status == 'FAILED':129 if status == 'FAILED':

Subscribers

People subscribed via source and target branches

to all changes: