Code review comment for lp:~thomir-deactivatedaccount/launchpad/devel-fix-git-links

Revision history for this message
Colin Watson (cjwatson) wrote :

I won't mention it at each site, but please sort imports. utilities/format-new-and-modified-imports can help with this (though it's worth double-checking what it does). Note also that imports are normally sorted case-insensitively in LP, even though I personally find that a bit weird.

I think some more tests should be updated:

lib/lp/app/doc/displaying-paragraphs-of-text.txt
lib/lp/app/javascript/tests/test_lp_links.*

... and the comment in lib/lp/app/javascript/lp-links.js should probably be updated too.

review: Needs Fixing

« Back to merge proposal