core result checker

Code review comment for lp:~thomir-deactivatedaccount/core-result-checker/trunk-detect-adt-status-and-republish-maybe

  1. trunk-detect-adt-status-and-republish-maybe
  2. Merge into trunk
Revision history for this message
Francis Ginther (fginther) wrote :

This looks wrong to me:

56 + q = self.connection.SimpleQueue(
57 + "core.tests.{}".format(constants.API_VERSION)
58 + )

Shouldn't the core.tests queue match the version that the previously ran this payload? Using the core-result-checker's API_VERSION would cause us to send messages to the wrong queue should the core-image-tester's API_VERSION get out of sync.

Do we actually need to have the name of the core-image-tester queue added to the payload so that the core-result-checker knows where to resend it?

review: Needs Information

« Back to merge proposal