Code review comment for lp:~thomir-deactivatedaccount/autopilot/merge-private-code

Revision history for this message
Olivier Tilloy (osomon) wrote :

I built a package from this MR, installed on my raring desktop, and tried to run the autopilot tests for lp:webbrowser-app.

Listing the tests fails with the following error:

    ImportError: cannot import name QtIntrospectionTestMixin

but can be easily fixed by simply removing this import, and not inheriting from QtIntrospectionTestMixin.

Running the tests fails with the following error:

_StringException: Traceback (most recent call last):
  File "/tmp/webbrowser-app/tests/autopilot/webbrowser_app/tests/test_mainwindow.py", line 263, in setUp
    super(TestMainWindowStartOpenRemotePageBase, self).setUp()
  File "/tmp/webbrowser-app/tests/autopilot/webbrowser_app/tests/__init__.py", line 161, in setUp
    super(BrowserTestCaseBaseWithHTTPServer, self).setUp()
  File "/tmp/webbrowser-app/tests/autopilot/webbrowser_app/tests/__init__.py", line 45, in setUp
    self.launch_test_local()
  File "/tmp/webbrowser-app/tests/autopilot/webbrowser_app/tests/__init__.py", line 62, in launch_test_local
    *self.ARGS)
  File "/usr/lib/python2.7/dist-packages/autopilot/testcase.py", line 450, in launch_test_application
    process = launch_application(launcher, application, *arguments, **kwargs)
  File "/usr/lib/python2.7/dist-packages/autopilot/introspection/__init__.py", line 80, in launch_application
    path, args = launcher.prepare_environment(application, list(arguments))
AttributeError: 'NoneType' object has no attribute 'prepare_environment'

Looks like a problem in autopilot itself.

« Back to merge proposal