Code review comment for lp:~thomir-deactivatedaccount/autopilot/1.3-fix-scan-speed

Revision history for this message
Martin Pitt (pitti) wrote :

I'm a bit sceptical that this is going to be long enough for ARM:

+ with maximum_runtime(5.0):

Also, I don't believe the rather complicated retry loop in _kill_process() isn't necessary, as in both py2 and py3 communicate() is documented to actually wait for the process to terminate.

Otherwise, LGTM. Still waiting for CI tests.

review: Approve

« Back to merge proposal