Code review comment for lp:~thomas-voss/unity8/explicit-gcc-version

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

This duplication is there again:

export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9

and

dh_auto_configure -- -DCMAKE_INSTALL_LOCALSTATEDIR="/var" -DCMAKE_C_COMPILER=$(CC) -DCMAKE_CXX_COMPILER=$(CXX)

You don't need to give these compiler flags to CMake, it will pick them up automatically from the envvars. In addition this definition is broken because it does not quote its arguments. So if, for example, in the future CC is set to "ccache gcc-whatever", this will break.

« Back to merge proposal