Code review comment for lp:~thomas-voss/unity-mir/oom_adjust

Revision history for this message
Gerry Boland (gerboland) wrote :

> > Please don't use the "Adj" abbreviation, it's vague. I'd recommend OomAdjuster.
Please address.

> As static constants are less likely to be hit by static initialization fiascos.
I don't understand this, these are integers, not static classes that have some interdependency.

> > + throw std::runtime_error("OomScoreAdj created with invalid value.");
> > This exception is not caught anywhere, as we tend to avoid using exceptions
> > in our Qt code.
I badly phrased this, I wanted you to remove the exception entirely as Qt is not fully exception safe: https://qt-project.org/doc/qt-5.0/qtdoc/exceptionsafety.html and so we avoid their use.

« Back to merge proposal