Merge lp:~thomas-voss/trust-store/fix-mir-comments into lp:trust-store

Proposed by Thomas Voß
Status: Merged
Approved by: Thomas Voß
Approved revision: 18
Merged at revision: 17
Proposed branch: lp:~thomas-voss/trust-store/fix-mir-comments
Merge into: lp:trust-store
Diff against target: 135 lines (+3/-80)
5 files modified
data/session.conf (+0/-42)
data/system.conf (+0/-23)
src/core/trust/impl/sqlite3/store.cpp (+3/-1)
tests/CMakeLists.txt (+0/-4)
tests/remote_trust_store_test.cpp (+0/-10)
To merge this branch: bzr merge lp:~thomas-voss/trust-store/fix-mir-comments
Reviewer Review Type Date Requested Status
Seth Arnold (community) Approve
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+226964@code.launchpad.net

Commit message

Remove obsolete data/session.conf and data/system.conf files.
Adjust directory creation default mode to 0755.

Description of the change

Remove obsolete data/session.conf and data/system.conf files.
Adjust directory creation default mode to 0755.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
18. By Thomas Voß

Remove obsolete header file.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Seth Arnold (seth-arnold) wrote :

Looks good to me, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== removed file 'data/session.conf'
--- data/session.conf 2014-05-06 11:32:13 +0000
+++ data/session.conf 1970-01-01 00:00:00 +0000
@@ -1,42 +0,0 @@
1<!DOCTYPE busconfig PUBLIC "-//freedesktop//DTD D-Bus Bus Configuration 1.0//EN"
2 "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd">
3<busconfig>
4 <!-- If we fork, keep the user's original umask to avoid affecting
5 the behavior of child processes. -->
6 <keep_umask/>
7
8 <type>session</type>
9
10 <listen>unix:tmpdir=/tmp</listen>
11
12 <standard_session_servicedirs />
13
14 <policy context="default">
15 <!-- Allow everything to be sent -->
16 <allow send_destination="*" eavesdrop="true"/>
17 <!-- Allow everything to be received -->
18 <allow eavesdrop="true"/>
19 <!-- Allow anyone to own anything -->
20 <allow own="*"/>
21 </policy>
22
23 <!-- raise the service start timeout to 40 seconds as it can timeout
24 on the live cd on slow machines -->
25 <limit name="service_start_timeout">60000</limit>
26
27 <!-- the memory limits are 1G instead of say 4G because they can't exceed 32-bit signed int max -->
28 <limit name="max_incoming_bytes">1000000000</limit>
29 <limit name="max_outgoing_bytes">1000000000</limit>
30 <limit name="max_message_size">1000000000</limit>
31 <limit name="service_start_timeout">120000</limit>
32 <limit name="auth_timeout">240000</limit>
33 <limit name="max_completed_connections">100000</limit>
34 <limit name="max_incomplete_connections">10000</limit>
35 <limit name="max_connections_per_user">100000</limit>
36 <limit name="max_pending_service_starts">10000</limit>
37 <limit name="max_names_per_connection">50000</limit>
38 <limit name="max_match_rules_per_connection">50000</limit>
39 <limit name="max_replies_per_connection">50000</limit>
40 <limit name="reply_timeout">300000</limit>
41
42</busconfig>
430
=== removed file 'data/system.conf'
--- data/system.conf 2014-05-06 11:32:13 +0000
+++ data/system.conf 1970-01-01 00:00:00 +0000
@@ -1,23 +0,0 @@
1<!DOCTYPE busconfig PUBLIC "-//freedesktop//DTD D-Bus Bus Configuration 1.0//EN"
2 "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd">
3<busconfig>
4 <!-- If we fork, keep the user's original umask to avoid affecting
5 the behavior of child processes. -->
6 <keep_umask/>
7
8 <type>system</type>
9
10 <listen>unix:tmpdir=/tmp</listen>
11
12 <standard_system_servicedirs/>
13
14 <policy context="default">
15 <!-- Allow everything to be sent -->
16 <allow send_destination="*" eavesdrop="true"/>
17 <!-- Allow everything to be received -->
18 <allow eavesdrop="true"/>
19 <!-- Allow anyone to own anything -->
20 <allow own="*"/>
21 </policy>
22
23</busconfig>
240
=== modified file 'src/core/trust/impl/sqlite3/store.cpp'
--- src/core/trust/impl/sqlite3/store.cpp 2014-06-26 07:09:51 +0000
+++ src/core/trust/impl/sqlite3/store.cpp 2014-07-16 21:34:23 +0000
@@ -50,10 +50,12 @@
50{50{
51 Directory(const std::string& name)51 Directory(const std::string& name)
52 {52 {
53 // Default permissions for directory creation.
54 mode_t default_mode = 0755;
53 // This is only a helper and we are consciously ignoring55 // This is only a helper and we are consciously ignoring
54 // errors. We will fail later on when trying to opening the56 // errors. We will fail later on when trying to opening the
55 // database, anyway.57 // database, anyway.
56 mkdir(name.c_str(), 0777);58 mkdir(name.c_str(), default_mode);
57 }59 }
58};60};
5961
6062
=== modified file 'tests/CMakeLists.txt'
--- tests/CMakeLists.txt 2014-05-06 11:32:13 +0000
+++ tests/CMakeLists.txt 2014-07-16 21:34:23 +0000
@@ -12,10 +12,6 @@
1212
13add_definitions(-DCORE_DBUS_ENABLE_GOOGLE_TEST_FIXTURE)13add_definitions(-DCORE_DBUS_ENABLE_GOOGLE_TEST_FIXTURE)
1414
15configure_file(
16 ${CMAKE_CURRENT_SOURCE_DIR}/test_data.h.in
17 ${CMAKE_CURRENT_BINARY_DIR}/test_data.h @ONLY)
18
19include_directories(15include_directories(
20 ${CMAKE_CURRENT_BINARY_DIR}16 ${CMAKE_CURRENT_BINARY_DIR}
21 ${GTEST_INCLUDE_DIRS}17 ${GTEST_INCLUDE_DIRS}
2218
=== modified file 'tests/remote_trust_store_test.cpp'
--- tests/remote_trust_store_test.cpp 2014-05-06 11:32:13 +0000
+++ tests/remote_trust_store_test.cpp 2014-07-16 21:34:23 +0000
@@ -28,8 +28,6 @@
28#include <core/testing/cross_process_sync.h>28#include <core/testing/cross_process_sync.h>
29#include <core/testing/fork_and_run.h>29#include <core/testing/fork_and_run.h>
3030
31#include "test_data.h"
32
33#include <gtest/gtest.h>31#include <gtest/gtest.h>
3432
35#include <chrono>33#include <chrono>
@@ -42,14 +40,6 @@
42struct RemoteTrustStore : public core::dbus::testing::Fixture40struct RemoteTrustStore : public core::dbus::testing::Fixture
43{41{
44};42};
45
46auto session_bus_config_file =
47 core::dbus::testing::Fixture::default_session_bus_config_file() =
48 core::testing::session_bus_configuration_file();
49
50auto system_bus_config_file =
51 core::dbus::testing::Fixture::default_system_bus_config_file() =
52 core::testing::system_bus_configuration_file();
53}43}
5444
55TEST_F(RemoteTrustStore, a_store_exposed_to_the_session_can_be_reset)45TEST_F(RemoteTrustStore, a_store_exposed_to_the_session_can_be_reset)

Subscribers

People subscribed via source and target branches