Code review comment for lp:~thomas-voss/process-cpp/fix-death-observer

Revision history for this message
Thomas Voß (thomas-voss) wrote :

> And yes, the packaging changes look fine to me, so core-dev ack on that. The
> silo will need to contain all of dbus-cpp, unity-mir, and unity-scopes-api;

Yup, preparing.

> and possibly also connectivity-api, platform-api, and qtubuntu-sensors (why do
> these build-depend on libprocess-cpp-dev but have no run-time dependency?
> That seems suspicious).

These packages only leverage the out-of-process testing capabilities of process-cpp at buildtime.

« Back to merge proposal