Code review comment for lp:~thomas-voss/platform-api/introduce-hardware-subdirectory-and-package

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

dpkg-gensymbols: warning: debian/libplatform-api1-hybris/DEBIAN/symbols doesn't match completely debian/libplatform-api1-hybris.symbols
--- debian/libplatform-api1-hybris.symbols (libplatform-api1-hybris_0.18.1daily13.06.25-0ubuntu1_amd64)
+++ dpkg-gensymbolsgDxpna 2013-06-25 19:19:39.687312411 +0000
@@ -1,105 +1,95 @@
-libubuntu_application_api.so.1 libplatform-api1-hybris #MINVER#

Please update the symbols file.

289 === modified file 'debian/libplatform-api1-dev.install'
290 --- debian/libplatform-api1-dev.install 2013-06-25 19:14:28 +0000
291 +++ debian/libplatform-api1-dev.install 2013-06-25 19:14:28 +0000
292 @@ -1,2 +1,3 @@
293 -usr/lib/*/libubuntu_application_api.so
294 +usr/lib/*/libubuntu_application_api.so*
295 +usr/lib/*/libubuntu_platform_hardware_api.so*

Only ".so" should be part of libplatform-api1-dev.install. Please include the ".so.*" ones in libplatform-api1-hybris.install.

review: Needs Fixing

« Back to merge proposal