Merge lp:~thomas-voss/platform-api/explicit-gcc-version into lp:platform-api

[Thomas Voß]

Explicitly select g++-4.9 to prevent from ABI breaks.

Explicitly select g++-4.9 to prevent from ABI breaks.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:234
http://jenkins.qa.ubuntu.com/job/platform-api-ci/337/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-amd64-ci/70/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-armhf-ci/70/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-utopic-i386-ci/70/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/337/rebuild

review: Needs Fixing (continuous-integration)

[Colin Watson (cjwatson)]

Why the change in ubuntu-application-api2-touch's package name? If that's intentional, then you haven't also renamed debian/ubuntu-application-api2-touch.install, which is why you have build failures.

I notice you haven't bumped the SONAME here. Does platform-api shield its users from the C++ implementation details?

review: Needs Fixing

[lp:~thomas-voss/platform-api/explicit-gcc-version]

235. By Steve Langasek on 2014-07-12

Revert accidental binary package rename, causing a build failure

[Steve Langasek (vorlon)]

The symbols files show that these packages only export a C ABI, so there are no C++11 ABI problems here. Of course, the binary package name change is still fatal here and should be reverted.

Superseded by https://code.launchpad.net/~vorlon/platform-api/explicit-gcc-version/+merge/226566

review: Disapprove

Unmerged revisions

=== modified file 'debian/changelog'
--- debian/changelog	2014-06-24 20:22:48 +0000
+++ debian/changelog	2014-06-27 08:38:00 +0000
@@ -1,3 +1,9 @@
+platform-api (2.1.0+14.10.20140624.4-0ubuntu2) UNRELEASED; urgency=medium
+
+  * Explicitly select g++-4.9 to prevent from ABI breaks.
+
+ -- Thomas Voß <[e-mail]>  Fri, 27 Jun 2014 10:36:28 +0200
+
 platform-api (2.1.0+14.10.20140624.4-0ubuntu1) utopic; urgency=low
 
   [ Ricardo Mendoza ]
 
=== modified file 'debian/control'
--- debian/control	2014-06-13 16:31:35 +0000
+++ debian/control	2014-06-27 08:38:00 +0000
@@ -7,6 +7,10 @@
                debhelper (>= 9),
                doxygen,
                graphviz,
+# We rely on C++11 features, and to prevent from ABI breaks
+# in libstdc++ causing us issues, we explicitly select a G++
+# version.
+               g++-4.9,
                libgles2-mesa-dev,
                libhybris-common-dev,
                pkg-config,
@@ -77,7 +81,7 @@
  This package provides the development library and headers (via
  dependency) for the Ubuntu Application API.
 
-Package: ubuntu-application-api2-touch
+Package: ubuntu-application-api-touch
 Section: libs
 Pre-Depends: ${misc:Pre-Depends},
 Multi-Arch: same
 
=== modified file 'debian/rules'
--- debian/rules	2014-05-20 14:24:10 +0000
+++ debian/rules	2014-06-27 08:38:00 +0000
@@ -2,9 +2,19 @@
 
 DPKG_GENSYMBOLS_CHECK_LEVEL = 4
 
+include /usr/share/dpkg/default.mk
+
+# Explicitly selecting a G{CC,++}-version here to avoid accidental
+# ABI breaks introduced by toolchain updates.
+export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
+export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
+
 %:
 	dh $@
 
+override_dh_auto_configure:
+	dh_auto_configure -- -DCMAKE_C_COMPILER=$(CC) -DCMAKE_CXX_COMPILER=$(CXX)
+
 override_dh_install:
 	dh_install --fail-missing