Merge lp:~thomas-voss/platform-api/build-modules-as-shared-libraries into lp:platform-api

Proposed by Thomas Voß
Status: Needs review
Proposed branch: lp:~thomas-voss/platform-api/build-modules-as-shared-libraries
Merge into: lp:platform-api
Diff against target: 38 lines (+3/-3)
3 files modified
src/ubuntu/application/desktop/CMakeLists.txt (+1/-1)
src/ubuntu/application/testbackend/CMakeLists.txt (+1/-1)
src/ubuntu/application/touch/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~thomas-voss/platform-api/build-modules-as-shared-libraries
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Simon Fels Approve
Review via email: mp+290571@code.launchpad.net

Commit message

Build backend modules as actual shared libraries to force creation of version so symlinks.
See https://cmake.org/cmake/help/v3.5/release/3.4.html#id13 for the behavioral change in CMake.

Description of the change

Build backend modules as actual shared libraries to force creation of version so symlinks.
See https://cmake.org/cmake/help/v3.5/release/3.4.html#id13 for the behavioral change in CMake.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

Revision history for this message
Simon Fels (morphis) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

320. By Thomas Voß

Build backend modules as actual shared libraries to force creation of version so symlinks.
See https://cmake.org/cmake/help/v3.5/release/3.4.html#id13 for the behavioral change in CMake.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/ubuntu/application/desktop/CMakeLists.txt'
--- src/ubuntu/application/desktop/CMakeLists.txt 2015-06-18 00:36:42 +0000
+++ src/ubuntu/application/desktop/CMakeLists.txt 2016-03-31 07:56:19 +0000
@@ -1,7 +1,7 @@
1set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11")1set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11")
22
3add_library(3add_library(
4 ubuntu_application_api_desktop_mirclient MODULE4 ubuntu_application_api_desktop_mirclient SHARED
55
6 module.cpp6 module.cpp
7 module_version.h7 module_version.h
88
=== modified file 'src/ubuntu/application/testbackend/CMakeLists.txt'
--- src/ubuntu/application/testbackend/CMakeLists.txt 2014-05-29 13:56:37 +0000
+++ src/ubuntu/application/testbackend/CMakeLists.txt 2016-03-31 07:56:19 +0000
@@ -1,7 +1,7 @@
1set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11")1set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11")
22
3add_library(3add_library(
4 ubuntu_application_api_test MODULE4 ubuntu_application_api_test SHARED
5 5
6 ubuntu_application_sensors.cpp6 ubuntu_application_sensors.cpp
7 module.cpp7 module.cpp
88
=== modified file 'src/ubuntu/application/touch/CMakeLists.txt'
--- src/ubuntu/application/touch/CMakeLists.txt 2015-06-18 00:36:42 +0000
+++ src/ubuntu/application/touch/CMakeLists.txt 2016-03-31 07:56:19 +0000
@@ -3,7 +3,7 @@
3add_subdirectory(hybris)3add_subdirectory(hybris)
44
5add_library(5add_library(
6 ubuntu_application_api_touch_mirclient MODULE6 ubuntu_application_api_touch_mirclient SHARED
77
8 module.cpp8 module.cpp
9 module_version.h9 module_version.h

Subscribers

People subscribed via source and target branches