Merge lp:~thomas-voss/platform-api/build-modules-as-shared-libraries into lp:platform-api

Proposed by Thomas Voß
Status: Needs review
Proposed branch: lp:~thomas-voss/platform-api/build-modules-as-shared-libraries
Merge into: lp:platform-api
Diff against target: 38 lines (+3/-3)
3 files modified
src/ubuntu/application/desktop/CMakeLists.txt (+1/-1)
src/ubuntu/application/testbackend/CMakeLists.txt (+1/-1)
src/ubuntu/application/touch/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~thomas-voss/platform-api/build-modules-as-shared-libraries
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Simon Fels Approve
Review via email: mp+290571@code.launchpad.net

Commit message

Build backend modules as actual shared libraries to force creation of version so symlinks.
See https://cmake.org/cmake/help/v3.5/release/3.4.html#id13 for the behavioral change in CMake.

Description of the change

Build backend modules as actual shared libraries to force creation of version so symlinks.
See https://cmake.org/cmake/help/v3.5/release/3.4.html#id13 for the behavioral change in CMake.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

Revision history for this message
Simon Fels (morphis) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

320. By Thomas Voß

Build backend modules as actual shared libraries to force creation of version so symlinks.
See https://cmake.org/cmake/help/v3.5/release/3.4.html#id13 for the behavioral change in CMake.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntu/application/desktop/CMakeLists.txt'
2--- src/ubuntu/application/desktop/CMakeLists.txt 2015-06-18 00:36:42 +0000
3+++ src/ubuntu/application/desktop/CMakeLists.txt 2016-03-31 07:56:19 +0000
4@@ -1,7 +1,7 @@
5 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11")
6
7 add_library(
8- ubuntu_application_api_desktop_mirclient MODULE
9+ ubuntu_application_api_desktop_mirclient SHARED
10
11 module.cpp
12 module_version.h
13
14=== modified file 'src/ubuntu/application/testbackend/CMakeLists.txt'
15--- src/ubuntu/application/testbackend/CMakeLists.txt 2014-05-29 13:56:37 +0000
16+++ src/ubuntu/application/testbackend/CMakeLists.txt 2016-03-31 07:56:19 +0000
17@@ -1,7 +1,7 @@
18 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11")
19
20 add_library(
21- ubuntu_application_api_test MODULE
22+ ubuntu_application_api_test SHARED
23
24 ubuntu_application_sensors.cpp
25 module.cpp
26
27=== modified file 'src/ubuntu/application/touch/CMakeLists.txt'
28--- src/ubuntu/application/touch/CMakeLists.txt 2015-06-18 00:36:42 +0000
29+++ src/ubuntu/application/touch/CMakeLists.txt 2016-03-31 07:56:19 +0000
30@@ -3,7 +3,7 @@
31 add_subdirectory(hybris)
32
33 add_library(
34- ubuntu_application_api_touch_mirclient MODULE
35+ ubuntu_application_api_touch_mirclient SHARED
36
37 module.cpp
38 module_version.h

Subscribers

People subscribed via source and target branches