Code review comment for lp:~thomas-voss/platform-api/add-package-config

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

71 + dh_link include/ubuntu-${UBUNTU_PLATFORM_API_VERSION_MAJOR} include/ubuntu

debian/rules doesn't know about UBUNTU_PLATFORM_API_VERSION_MAJOR.

Also, while you're on it, mind cleaning debian/rules to remove the -DUSE_GLES part?

Follows a suggestion for a fix:
"""
=== added file 'debian/libplatform-api-headers.links'
--- debian/libplatform-api-headers.links 1970-01-01 00:00:00 +0000
+++ debian/libplatform-api-headers.links 2013-07-04 04:43:51 +0000
@@ -0,0 +1,1 @@
+usr/include/ubuntu-1 usr/include/ubuntu

=== modified file 'debian/rules'
--- debian/rules 2013-07-03 07:23:59 +0000
+++ debian/rules 2013-07-04 04:44:23 +0000
@@ -4,19 +4,8 @@

 export CXX=g++-4.7

-gles2_architectures := armhf
-ifeq ($(DEB_HOST_ARCH),$(findstring $(DEB_HOST_ARCH), $(gles2_architectures)))
- use_gles=1
-else
- use_gles=0
-endif
-
 %:
  dh $@

-override_dh_auto_configure:
- dh_auto_configure -- -DUSE_GLES=$(use_gles)
-
 overrid_dh_install:
  dh_install --fail-missing
- dh_link include/ubuntu-${UBUNTU_PLATFORM_API_VERSION_MAJOR} include/ubuntu

"""

You don't need to worry much about the hardcoded major version as this is just a temporary fix while we rebuild/fix the other packages.

review: Needs Fixing

« Back to merge proposal