Code review comment for lp:~thomas-voss/platform-api/add-package-config

Revision history for this message
Thomas Voß (thomas-voss) wrote :

> 76 +Architecture: any
> 85 +Architecture: any
>
> As we don't have hybris for powerpc I'm not sure if moving to any is the right
> choice.

I will cross-check with didrocks.

>
> 138 - DESTINATION include/ubuntu/application/sensors/event
> 139 + DESTINATION
> include/ubuntu-${UBUNTU_PLATFORM_API_VERSION_MAJOR}/application/sensors/event
>
> 150 - DESTINATION include/ubuntu/application/ui
> 151 + DESTINATION
> include/ubuntu-${UBUNTU_PLATFORM_API_VERSION_MAJOR}/application/ui
>
> 164 - DESTINATION include/ubuntu/application/ui/input
> 165 + DESTINATION
> include/ubuntu-${UBUNTU_PLATFORM_API_VERSION_MAJOR}/application/ui/input
>
> 175 - DESTINATION include/ubuntu/ui
> 176 + DESTINATION include/ubuntu-${UBUNTU_PLATFORM_API_VERSION_MAJOR}/ui
>
> Before moving this forward, please have MRs for all the consumers as well (or
> create a temporarily link while you get the rest fixed).
>

I would rather prefer not releasing this version as there are likely more packaging changes coming down the pipe. I'm happy to provide patches for the consumers, but I would propose to do that in one go after we are happy with the packaging of the platform API.

> Otherwise this will create a ton of FTBFS.

Agreed :)

review: Approve

« Back to merge proposal