Code review comment for lp:~thomas-voss/net-cpp/bug-fixing-and-features-landing

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Thanks tvoss for this MP, it looks good to me.
In this MP, I didn't see pause/resume issue anymore.
I think i should put speed.{limit, duration} into Request::Configuration struct in my MP just as what you do in this MP since we already have this struct there.
I really like the implementation of progress bar, it's quite neat and simple.
Thanks again.

P.S I forget we have sth available in CI labs. :)

review: Approve

« Back to merge proposal