Mir

Code review comment for lp:~thomas-voss/mir/fix-fd-sharing

Revision history for this message
Thomas Voß (thomas-voss) wrote :

> Is the lambda run in the same thread as the caller?
> socket->get_io_service().dispatch(...
>

No, that's why the fds are copied into the lambda.

> If not then it is using fds unsafely unlocked and/or potentially after the
> object is destroyed.

It takes a copy of the fds to avoid this issue.

« Back to merge proposal