Mir

Code review comment for lp:~thomas-voss/mir/fix-fd-sharing

Revision history for this message
Chris Halse Rogers (raof) wrote :

Looks good to me.

Mostly; the lambda's capturing ‘fds’ by value which IIUC will imply another copy of the vector. Although this does mean that we don't need to care about synchronisation.

review: Approve

« Back to merge proposal