Mir

Code review comment for lp:~thomas-voss/mir/fix-fd-sharing

Revision history for this message

Thomas Voß (thomas-voss) wrote on 2013-08-19:

> 1. Have we observed any problems with "incorrect" ordering? What's being
> fixed?
>

The issue reported in https://bugs.launchpad.net/mir/+bug/1204939 might be triggered by incorrect ordering of operations on the underlying socket.

> 2. Please indent the lambda only 4 spaces in from the dispatch line. That
> should make it more readable.

fixed.