Mir

Code review comment for lp:~thomas-voss/mir/explicit-gcc-version

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

"/tmp/buildd/mir-0.4.0bzr1730pkg0utopic580/src/shared/graphics/android/syncfence.cpp: In member function 'virtual void mir::graphics::android::SyncFence::merge_with(mir::graphics::android::NativeFence&)':
/tmp/buildd/mir-0.4.0bzr1730pkg0utopic580/src/shared/graphics/android/syncfence.cpp:68:51: error: overflow in implicit constant conversion [-Werror=overflow]
         ops->ioctl(fence_fd, SYNC_IOC_MERGE, &data);
                                                   ^
cc1plus: all warnings being treated as errors"

Is this what happens when one forces g++4.9?

In which case the code needs fixing first. (Probably clearer as a separate, prerequisite MP)

review: Needs Fixing

« Back to merge proposal