Mir

Code review comment for lp:~thomas-voss/mir/explicit-gcc-version

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(1) debian/changelog modifications are way out of date. We're actually working on release 0.4.0 right now. The 0.2 series has its own branch. Regardless, all changes should start of the development branch so I think just drop the changelog modifications.

(2) Depending on g++-4.9 appears to be the first Mir code change to break compatibility with trusty. I guess that's OK so long as it's development branch and/or utopic branches only. Just worth mentioning.

(3) I'm a little concerned this could make people think _only_ gcc is supported. That's obviously not true as we can build with clang too.

The only real blocking issue is the changelog (1). It's also causing a merge conflict anyway.

review: Needs Fixing

« Back to merge proposal