Mir

Code review comment for lp:~thomas-voss/mir/add-pthread-linker-and-preprocessor-flags-2

  1. add-pthread-linker-and-preprocessor-flags-2
  2. Merge into development-branch
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This is incorrect and redundant:
+set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -pthread -Wl,--no-undefined")

Incorrect because it loses existing CMAKE_EXE_LINKER_FLAGS. And redundant because if you scroll down you'll find we already have:
  set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -pthread")

review: Needs Fixing

« Back to merge proposal