Code review comment for lp:~thomas-voss/media-hub/use-mpris-player-skeleton-and-register-with-indicator

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

1965 +media::PlayerSkeleton::PlayerSkeleton(const media::PlayerSkeleton::Configuration& config)

The following case is missing from this method:

    auto play_pause = std::bind(&Private::handle_play_pause, d, std::placeholders::_1);
    d->object->install_method_handler<mpris::Player::PlayPause>(play_pause);

review: Needs Fixing

« Back to merge proposal