Code review comment for lp:~thomas-voss/media-hub/introduce-video-sink-interface
Revision history for this message
| Thomas Voß (thomas-voss) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Looks good, just 1 inline comment below. Also, make sure to rebase with trunk
> changes.
They should be up to date, and the train takes care of remerging with trunk.
> This would be the very first MR I'd like to see get put into a silo
> so that I can test it well. This is a nice limited-scope MR but still is
> important. I want to try to avoid having to test all of the MRs combined in
> one silo, but instead would like to incrementally test one or 2 MRs at a time
> and land, then test 1 or two more and land, etc.
Well, I wonder if we could at least group together the introduce-MRs into one silo and collectively test them to avoid retesting the same thing over and over again.