Merge lp:~thomas-voss/media-hub/explicit-gcc-version into lp:media-hub

Proposed by Thomas Voß
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp:~thomas-voss/media-hub/explicit-gcc-version
Merge into: lp:media-hub
Diff against target: 115 lines (+28/-8)
5 files modified
CMakeLists.txt (+2/-2)
debian/changelog (+6/-0)
debian/control (+9/-5)
debian/libmedia-hub-common1.symbols (+1/-1)
debian/rules (+10/-0)
To merge this branch: bzr merge lp:~thomas-voss/media-hub/explicit-gcc-version
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove
Colin Watson Approve
PS Jenkins bot continuous-integration Needs Fixing
Matthias Klose Pending
Review via email: mp+224758@code.launchpad.net

Commit message

Bump major revision and so name to account for toolchain update.

Description of the change

Bump major revision and so name to account for toolchain update.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Steve Langasek (vorlon) wrote :
review: Disapprove

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2014-04-04 14:31:43 +0000
+++ CMakeLists.txt 2014-06-27 08:08:27 +0000
@@ -2,9 +2,9 @@
22
3project(ubuntu-media-hub)3project(ubuntu-media-hub)
44
5set(UBUNTU_MEDIA_HUB_VERSION_MAJOR 0)5set(UBUNTU_MEDIA_HUB_VERSION_MAJOR 1)
6set(UBUNTU_MEDIA_HUB_VERSION_MINOR 0)6set(UBUNTU_MEDIA_HUB_VERSION_MINOR 0)
7set(UBUNTU_MEDIA_HUB_VERSION_PATCH 1)7set(UBUNTU_MEDIA_HUB_VERSION_PATCH 0)
88
9set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror -Wall -pedantic -Wextra -fPIC -pthread")9set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror -Wall -pedantic -Wextra -fPIC -pthread")
10set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Werror -Wall -fno-strict-aliasing -pedantic -Wextra -fPIC -pthread")10set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Werror -Wall -fno-strict-aliasing -pedantic -Wextra -fPIC -pthread")
1111
=== modified file 'debian/changelog'
--- debian/changelog 2014-06-24 22:34:29 +0000
+++ debian/changelog 2014-06-27 08:08:27 +0000
@@ -1,3 +1,9 @@
1media-hub (1.0.0) UNRELEASED; urgency=medium
2
3 * Bump major revision and so name to account for toolchain update.
4
5 -- Thomas Voß <thomas.voss@canonical.com> Fri, 27 Jun 2014 10:02:53 +0200
6
1media-hub (0.0.2+14.10.20140624.4-0ubuntu1) utopic; urgency=low7media-hub (0.0.2+14.10.20140624.4-0ubuntu1) utopic; urgency=low
28
3 [ Alberto Aguirre ]9 [ Alberto Aguirre ]
410
=== modified file 'debian/control'
--- debian/control 2014-05-06 18:48:44 +0000
+++ debian/control 2014-06-27 08:08:27 +0000
@@ -11,12 +11,16 @@
11 graphviz,11 graphviz,
12 gstreamer1.0-plugins-good,12 gstreamer1.0-plugins-good,
13 gstreamer1.0-fluendo-mp3,13 gstreamer1.0-fluendo-mp3,
14# We rely on C++11 features, and to prevent from ABI breaks
15# in libstdc++ causing us issues, we explicitly select a G++
16# version.
17 g++-4.9,
14 libboost-dev (>=1.53),18 libboost-dev (>=1.53),
15 libboost-filesystem-dev (>=1.53),19 libboost-filesystem-dev (>=1.53),
16 libboost-program-options-dev (>=1.53),20 libboost-program-options-dev (>=1.53),
17 libboost-system-dev (>=1.53),21 libboost-system-dev (>=1.53),
18 libdbus-1-dev,22 libdbus-1-dev,
19 libdbus-cpp-dev (>= 3.0.0),23 libdbus-cpp-dev (>= 4.0.0),
20 libgoogle-glog-dev,24 libgoogle-glog-dev,
21 libhybris-dev (>=0.1.0+git20131207+e452e83-0ubuntu13),25 libhybris-dev (>=0.1.0+git20131207+e452e83-0ubuntu13),
22 libprocess-cpp-dev,26 libprocess-cpp-dev,
@@ -35,8 +39,8 @@
35Architecture: any39Architecture: any
36Multi-Arch: same40Multi-Arch: same
37Pre-Depends: dpkg (>= 1.15.6~)41Pre-Depends: dpkg (>= 1.15.6~)
38Depends: libmedia-hub-common0 (= ${binary:Version}),42Depends: libmedia-hub-common1 (= ${binary:Version}),
39 libmedia-hub-client0 (= ${binary:Version}),43 libmedia-hub-client1 (= ${binary:Version}),
40 ${misc:Depends},44 ${misc:Depends},
41 libproperties-cpp-dev,45 libproperties-cpp-dev,
42Suggests: libmedia-hub-doc46Suggests: libmedia-hub-doc
@@ -58,7 +62,7 @@
58 .62 .
59 This package contains the runtime.63 This package contains the runtime.
6064
61Package: libmedia-hub-common065Package: libmedia-hub-common1
62Architecture: any66Architecture: any
63Multi-Arch: same67Multi-Arch: same
64Pre-Depends: dpkg (>= 1.15.6~)68Pre-Depends: dpkg (>= 1.15.6~)
@@ -70,7 +74,7 @@
70 .74 .
71 This package contains the common libraries.75 This package contains the common libraries.
7276
73Package: libmedia-hub-client077Package: libmedia-hub-client1
74Architecture: any78Architecture: any
75Multi-Arch: same79Multi-Arch: same
76Pre-Depends: dpkg (>= 1.15.6~)80Pre-Depends: dpkg (>= 1.15.6~)
7781
=== renamed file 'debian/libmedia-hub-client0.install' => 'debian/libmedia-hub-client1.install'
=== renamed file 'debian/libmedia-hub-common0.install' => 'debian/libmedia-hub-common1.install'
=== renamed file 'debian/libmedia-hub-common0.symbols' => 'debian/libmedia-hub-common1.symbols'
--- debian/libmedia-hub-common0.symbols 2014-03-26 16:13:02 +0000
+++ debian/libmedia-hub-common1.symbols 2014-06-27 08:08:27 +0000
@@ -1,4 +1,4 @@
1libmedia-hub-common.so.0 libmedia-hub-common0 #MINVER#1libmedia-hub-common.so.1 libmedia-hub-common1 #MINVER#
2 (c++)"the_session_bus()@Base" 0.0.12 (c++)"the_session_bus()@Base" 0.0.1
3 (c++)"std::shared_ptr<core::dbus::Bus>::~shared_ptr()@Base" 0.0.13 (c++)"std::shared_ptr<core::dbus::Bus>::~shared_ptr()@Base" 0.0.1
4 (c++)"std::shared_ptr<core::dbus::Bus>::~shared_ptr()@Base" 0.0.14 (c++)"std::shared_ptr<core::dbus::Bus>::~shared_ptr()@Base" 0.0.1
55
=== modified file 'debian/rules'
--- debian/rules 2014-05-06 09:13:43 +0000
+++ debian/rules 2014-06-27 08:08:27 +0000
@@ -6,9 +6,19 @@
66
7export DPKG_GENSYMBOLS_CHECK_LEVEL=47export DPKG_GENSYMBOLS_CHECK_LEVEL=4
88
9include /usr/share/dpkg/default.mk
10
11# Explicitly selecting a G{CC,++}-version here to avoid accidental
12# ABI breaks introduced by toolchain updates.
13export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
14export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
15
9%:16%:
10 dh $@ --fail-missing -- -B build 17 dh $@ --fail-missing -- -B build
1118
19override_dh_auto_configure:
20 dh_auto_configure -- -DCMAKE_C_COMPILER=$(CC) -DCMAKE_CXX_COMPILER=$(CXX)
21
12override_dh_auto_test:22override_dh_auto_test:
13 env -u LD_PRELOAD dh_auto_test23 env -u LD_PRELOAD dh_auto_test
1424

Subscribers

People subscribed via source and target branches