Merge lp:~thomas-voss/location-service/to-gcc-4.8 into lp:location-service/trunk

Proposed by Thomas Voß
Status: Rejected
Rejected by: Sergio Schvezov
Proposed branch: lp:~thomas-voss/location-service/to-gcc-4.8
Merge into: lp:location-service/trunk
Diff against target: 80 lines (+11/-12)
4 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+7/-1)
debian/control (+3/-7)
debian/rules (+0/-3)
To merge this branch: bzr merge lp:~thomas-voss/location-service/to-gcc-4.8
Reviewer Review Type Date Requested Status
Sergio Schvezov Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Łukasz Zemczak Pending
Review via email: mp+218260@code.launchpad.net

Commit message

Patch version bump reflecting the toolchain switch.

Description of the change

Patch version bump reflecting the toolchain switch.

Are there any related MPs required for this MP to build/function as expected?
  * https://code.launchpad.net/~thomas-voss/dbus-cpp/to-gcc-4.8/+merge/218259

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes): Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?: Yes
Did you successfully run all tests found in your component's Test Plan: (https://wiki.ubuntu.com/Process/Merges/TestPlan/location-service) on device or emulator? Yes
If you changed the UI, was the change specified/approved by design? N/A
If you changed the packaging (debian), did you subscribe a core-dev to this MP? Yes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
62. By Thomas Voß

Version build deps on platform API hardware portions.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

18 +location-service (0.0.3) UNRELEASED; urgency=medium

this is missing the -0ubuntu1 part of the version (aka the packaging part of the version)

review: Needs Fixing
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

You will also need to merge trunk back in

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2013-10-14 06:11:15 +0000
+++ CMakeLists.txt 2014-05-06 14:39:31 +0000
@@ -4,7 +4,7 @@
44
5set(UBUNTU_LOCATION_SERVICE_VERSION_MAJOR 0)5set(UBUNTU_LOCATION_SERVICE_VERSION_MAJOR 0)
6set(UBUNTU_LOCATION_SERVICE_VERSION_MINOR 0)6set(UBUNTU_LOCATION_SERVICE_VERSION_MINOR 0)
7set(UBUNTU_LOCATION_SERVICE_VERSION_PATCH 2)7set(UBUNTU_LOCATION_SERVICE_VERSION_PATCH 3)
88
9set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -pedantic -Wextra -fPIC -pthread")9set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -pedantic -Wextra -fPIC -pthread")
10set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -fno-strict-aliasing -pedantic -Wextra -fPIC -pthread")10set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -fno-strict-aliasing -pedantic -Wextra -fPIC -pthread")
1111
=== modified file 'debian/changelog'
--- debian/changelog 2014-03-07 12:42:42 +0000
+++ debian/changelog 2014-05-06 14:39:31 +0000
@@ -1,7 +1,13 @@
1location-service (0.0.3) UNRELEASED; urgency=medium
2
3 * Patch version bump reflecting the toolchain switch.
4
5 -- Thomas Voß <thomas.voss@canonical.com> Mon, 05 May 2014 11:13:33 +0200
6
1location-service (0.0.2+14.04.20140307-0ubuntu1) trusty; urgency=low7location-service (0.0.2+14.04.20140307-0ubuntu1) trusty; urgency=low
28
3 [ thomas-voss ]9 [ thomas-voss ]
4 * Reenable onSessionDied().10 * Re-enable onSessionDied().
511
6 [ Łukasz 'sil2100' Zemczak ]12 [ Łukasz 'sil2100' Zemczak ]
7 * Bump the build-dependency on dbus-cpp due to the ABI change13 * Bump the build-dependency on dbus-cpp due to the ABI change
814
=== modified file 'debian/control'
--- debian/control 2014-02-25 17:24:21 +0000
+++ debian/control 2014-05-06 14:39:31 +0000
@@ -1,5 +1,3 @@
1# Using g{cc,++} 4.7 as the platform-api consumes it and the platform
2# api is stuck with android's 4.7 toolchain.
3Source: location-service1Source: location-service
4Section: utils2Section: utils
5Priority: optional3Priority: optional
@@ -7,12 +5,10 @@
7XSBC-Original-Maintainer: Thomas Voß <thomas.voss@canonical.com>5XSBC-Original-Maintainer: Thomas Voß <thomas.voss@canonical.com>
8Build-Depends: cmake,6Build-Depends: cmake,
9 curl,7 curl,
10 libdbus-cpp-dev (>= 2.0.0),8 libdbus-cpp-dev (>= 3.0.0),
11 dbus-test-runner,9 dbus-test-runner,
12 debhelper (>= 9),10 debhelper (>= 9),
13 doxygen,11 doxygen,
14 gcc-4.7,
15 g++-4.7,
16 geoclue-ubuntu-geoip,12 geoclue-ubuntu-geoip,
17 google-mock (>= 1.6.0+svn437),13 google-mock (>= 1.6.0+svn437),
18 graphviz,14 graphviz,
@@ -22,8 +18,8 @@
22 libgoogle-glog-dev,18 libgoogle-glog-dev,
23 libgtest-dev,19 libgtest-dev,
24 libiw-dev,20 libiw-dev,
25 libplatform-hardware-api-headers,21 libplatform-hardware-api-headers (>=0.21),
26 libplatform-hardware-api1-dev,22 libplatform-hardware-api1-dev (>=0.21),
27 libproperties-cpp-dev,23 libproperties-cpp-dev,
28Standards-Version: 3.9.424Standards-Version: 3.9.4
29Homepage: http://launchpad.net/location-service25Homepage: http://launchpad.net/location-service
3026
=== modified file 'debian/rules'
--- debian/rules 2014-02-05 13:25:11 +0000
+++ debian/rules 2014-05-06 14:39:31 +0000
@@ -11,9 +11,6 @@
1111
12DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)12DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
1313
14export CC=gcc-4.7
15export CXX=g++-4.7
16
17export DPKG_GENSYMBOLS_CHECK_LEVEL=414export DPKG_GENSYMBOLS_CHECK_LEVEL=4
1815
19%:16%:

Subscribers

People subscribed via source and target branches