Merge lp:~thomas-voss/location-service/iterate-on-galileo-handling into lp:location-service

Proposed by Thomas Voß
Status: Merged
Approved by: Thomas Voß
Approved revision: 292
Merged at revision: 293
Proposed branch: lp:~thomas-voss/location-service/iterate-on-galileo-handling
Merge into: lp:location-service
Diff against target: 53 lines (+5/-2)
3 files modified
src/location/providers/ubx/_8/nmea/generator.h (+2/-1)
src/location/providers/ubx/_8/nmea/grammar.h (+2/-1)
src/location/providers/ubx/_8/nmea/talker.h (+1/-0)
To merge this branch: bzr merge lp:~thomas-voss/location-service/iterate-on-galileo-handling
Reviewer Review Type Date Requested Status
Simon Fels (community) Approve
Thomas Voß Pending
Review via email: mp+319409@code.launchpad.net

Commit message

Enable support for GALILEO talker id.

Description of the change

Enable support for GALILEO talker id.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/location/providers/ubx/_8/nmea/generator.h'
--- src/location/providers/ubx/_8/nmea/generator.h 2016-10-10 09:15:40 +0000
+++ src/location/providers/ubx/_8/nmea/generator.h 2017-03-09 09:45:55 +0000
@@ -58,6 +58,7 @@
58 field_separator %= ',';58 field_separator %= ',';
59 checksum %= boost::spirit::karma::hex;59 checksum %= boost::spirit::karma::hex;
60 talker.add60 talker.add
61 (Talker::ga, "GA")
61 (Talker::gl, "GL")62 (Talker::gl, "GL")
62 (Talker::gn, "GN")63 (Talker::gn, "GN")
63 (Talker::gp, "GP");64 (Talker::gp, "GP");
@@ -165,7 +166,7 @@
165 << boost::spirit::karma::maxwidth(1)[-boost::spirit::karma::uint_generator<std::uint8_t, 10>()] << field_separator166 << boost::spirit::karma::maxwidth(1)[-boost::spirit::karma::uint_generator<std::uint8_t, 10>()] << field_separator
166 << boost::spirit::karma::maxwidth(1)[-boost::spirit::karma::uint_generator<std::uint8_t, 10>()] << field_separator167 << boost::spirit::karma::maxwidth(1)[-boost::spirit::karma::uint_generator<std::uint8_t, 10>()] << field_separator
167 << boost::spirit::karma::right_align(2, '0')[-boost::spirit::karma::uint_generator<std::uint16_t, 10>()]168 << boost::spirit::karma::right_align(2, '0')[-boost::spirit::karma::uint_generator<std::uint16_t, 10>()]
168 << +(gsv_info);169 << *(gsv_info);
169170
170 rmc %= talker << "RMC" << field_separator171 rmc %= talker << "RMC" << field_separator
171 << -utc << field_separator172 << -utc << field_separator
172173
=== modified file 'src/location/providers/ubx/_8/nmea/grammar.h'
--- src/location/providers/ubx/_8/nmea/grammar.h 2016-10-10 09:15:40 +0000
+++ src/location/providers/ubx/_8/nmea/grammar.h 2017-03-09 09:45:55 +0000
@@ -60,6 +60,7 @@
60 field_separator %= ',';60 field_separator %= ',';
61 checksum %= boost::spirit::qi::hex;61 checksum %= boost::spirit::qi::hex;
62 talker.add62 talker.add
63 ("GA", Talker::ga)
63 ("GL", Talker::gl)64 ("GL", Talker::gl)
64 ("GN", Talker::gn)65 ("GN", Talker::gn)
65 ("GP", Talker::gp);66 ("GP", Talker::gp);
@@ -164,7 +165,7 @@
164 >> -boost::spirit::qi::uint_parser<std::uint8_t, 10, 1, 1>() >> field_separator165 >> -boost::spirit::qi::uint_parser<std::uint8_t, 10, 1, 1>() >> field_separator
165 >> -boost::spirit::qi::uint_parser<std::uint8_t, 10, 1, 1>() >> field_separator166 >> -boost::spirit::qi::uint_parser<std::uint8_t, 10, 1, 1>() >> field_separator
166 >> -boost::spirit::qi::uint_parser<std::uint16_t, 10, 2, 2>()167 >> -boost::spirit::qi::uint_parser<std::uint16_t, 10, 2, 2>()
167 >> +(gsv_info);168 >> *(gsv_info);
168169
169 rmc %= talker >> "RMC" >> field_separator170 rmc %= talker >> "RMC" >> field_separator
170 >> -utc >> field_separator171 >> -utc >> field_separator
171172
=== modified file 'src/location/providers/ubx/_8/nmea/talker.h'
--- src/location/providers/ubx/_8/nmea/talker.h 2016-10-10 09:15:40 +0000
+++ src/location/providers/ubx/_8/nmea/talker.h 2017-03-09 09:45:55 +0000
@@ -28,6 +28,7 @@
28/// @brief Talker enumerates well-known participants on an NMEA bus.28/// @brief Talker enumerates well-known participants on an NMEA bus.
29enum class Talker29enum class Talker
30{30{
31 ga, ///< GALILEO receiver
31 gl, ///< GLONASS receiver32 gl, ///< GLONASS receiver
32 gn, ///< Global Navigation Satellite System (GNSS)33 gn, ///< Global Navigation Satellite System (GNSS)
33 gp ///< Global Positioning System (GPS)34 gp ///< Global Positioning System (GPS)

Subscribers

People subscribed via source and target branches

to all changes: