Code review comment for lp:~thomas-voss/location-service/enable-dual-landings-take-2

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

Hey! Thanks for submitting this branch, would be nice to dual-land this.

So there's one small thing that's 'Needs Fixing' and two 'Needs Information'.

Needs Fixing:
You would need to include the changelog entry for this landing in the changelog diff here since this file has been touched. Train in such cases won't add the changelog entry based on the commit message in this case. Be sure to leave it as UNRELEASED.

Needs Information:
Small thing: I was wondering, I see we have an explicit -dbg package. Aren't those auto-generated on uploads? Just wondering if in this case we need one explicitly.
The second one is, of course, any chance for ABI compliance checking + some shlibs? ;) I suppose we export some symbols here, would be nice to have the some checks here for dual landing. Not sure how far Michi went with implementing abigail [1] in his ABI checking - I see there are some commits in their staging branch.

[1] https://sourceware.org/libabigail/

review: Needs Fixing

« Back to merge proposal