Code review comment for lp:~thomas-voss/location-service/add-testing-for-remote-provider

Revision history for this message
Loïc Minier (lool) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

I've tested with updated espoo binaries which need to land at the same time as updated packages; the espoo MP is already merged though.

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

On device

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/location-service) on device or emulator?

Ran most of the tests; discovered some not directly related issues, but no regressions

If you changed the UI, was the change specified/approved by design?

No UI change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

No packaging change

Did CI run pass? If not, please explain why.

CI passed

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

I'm filling it instead

« Back to merge proposal