Code review comment for lp:~thomas-voss/dbus-cpp/add_service_with_custom_name

Revision history for this message
Pete Woods (pete-woods) wrote :

> > Please add a couple of assertions around the behaviour of announcing policy.
> > Other than that, looks good. :)
>
> Added a simple test for a signal being invoked in TEST_F(Service,
> AddingServiceAndObjectAndCallingIntoItSucceeds).

Awesome stuff.

review: Approve

« Back to merge proposal