Code review comment for lp:~thomas-moenicke/ubuntu-keyboard/ubuntu-keyboard-qml-port

Revision history for this message
Bill Filler (bfiller) wrote :

General problems:

1) swiping within the keyboard should not make it move, only swiping from above. just like we fixed maliit keyboard to do.
2) key magnification is displayed partially behind the keys, press the "y" key to see what I mean. Should always be on top.
3) key magnifier shouldn't be displayed on special keys. we made this fix for maliit keyboard. spacebar, backspace, return, shift, other special keys..
4) key magnifier is cutoff on edges, try pressing "q" and "p" to see what I mean.
5) extended key popover should only be displayed if in fact the layout has extended keys. currently it's always displayed with an empty list if the key has no extended keys.
6) extended key popover not getting drawn correctly - even for keys that have extended characters (like a and e) I always see a transparent popover with no characters. just once I saw characters in it. It shouldn't be transparent either, should be solid.
7) extended key: when displaying the popover the key magnifier is still visible until you release your finger. key magnifier should be hidden as soon as popover is displayed. don't wait till key release.

US layout problems:
1) ?123 key graphic is too small
2) ABC key (after pressing ?123 key) graphic too small
3) when press ?123 key, the shift key shows both "up" arrow and "1/2" graphic. Should only show "1/2" graphic. Same with "2/2" key.
4) Can't type capital letters. Pressing the shift shows uppercase in the layout but lower case keys entered in input field
5) Caps lock doesn't work. I believe it use to be double clicking shift key would get you in caps-lock mode.

Url layout:
1) .com key graphic too big in landscape mode, it bleeds outside of key
2) the .com key is suppose to replace the spacebar key (see section 3.2 in https://docs.google.com/a/canonical.com/document/d/1UunhUqLkUiAhsy9iu_Pu3Sn6jUTCn3d7E8WxkfT6ZVQ/edit). I see it next to the space bar for <input type="url"> fields
3) the .com key is supposed to have extended key popovers for .co.uk, .net, .org, .edu, .gov, .ac.uk (see section 3.2)
4) the browser url field should use the url+search layout and the <input type="url"> should use url layout. What different input method hints are needed to support both of these?

Telephone number layout:
1) layout issues:
- need more space around left and right edges
- bottom row is not aligned with other rows (backspace key too big)
2) label for "+" key should be "+*#"
3) extended keys for "+*#" should show + * # ( )

Number layout:
1) Same issues as above 1) and 2)
2) . and - should be shown in extended keys

Email layout:
1) .com key too big and number key too small

review: Needs Fixing

« Back to merge proposal