U1DB

Code review comment for lp:~thisfred/u1db/fix-local-gen-before-sync

fix-local-gen-before-sync
Merge into trunk

Revision history for this message

Ubuntu One Auto Pilot (otto-pilot) wrote on 2012-08-15:

The attempt to merge lp:~thisfred/u1db/fix-local-gen-before-sync into lp:u1db failed. Below is the output from the failed tests.

-- The C compiler identification is GNU 4.7.1
-- The CXX compiler identification is GNU 4.7.1
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found Cython: /usr/bin/cython
-- Found CURL: /usr/lib/x86_64-linux-gnu/libcurl.so (found version "7.26.0")
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.26")
-- checking for module 'oauth'
-- found oauth, version 0.9.7
-- Found OAuth: /usr/lib/x86_64-linux-gnu/liboauth.so
-- checking for module 'json'
-- found json, version 0.9
-- Found JSON: /usr/lib/x86_64-linux-gnu/libjson.so
-- checking for module 'sqlite3'
-- found sqlite3, version 3.7.13
-- Found Sqlite3: /usr/lib/x86_64-linux-gnu/libsqlite3.so
-- Configuring done
-- Generating done
-- Build files have been written to: /mnt/tarmac/cache/u1db/trunk
[ 11%] Generating u1db_schema.c
Scanning dependencies of target u1db
[ 22%] Building C object src/CMakeFiles/u1db.dir/mkstemp_compat.c.o
[ 33%] Building C object src/CMakeFiles/u1db.dir/u1db.c.o
[ 44%] Building C object src/CMakeFiles/u1db.dir/u1db_http_sync_target.c.o
[ 55%] Building C object src/CMakeFiles/u1db.dir/u1db_query.c.o
[ 66%] Building C object src/CMakeFiles/u1db.dir/u1db_sync_target.c.o
[ 77%] Building C object src/CMakeFiles/u1db.dir/u1db_uuid.c.o
[ 88%] Building C object src/CMakeFiles/u1db.dir/u1db_vectorclock.c.o
[100%] Building C object src/CMakeFiles/u1db.dir/u1db_schema.c.o
Linking C static library libu1db.a
[100%] Built target u1db
Scanning dependencies of target ReplicatePythonSourceTree
[100%] Built target ReplicatePythonSourceTree
Scanning dependencies of target build-debug
running build_ext
cythoning u1db/tests/c_backend_wrapper.pyx to u1db/tests/c_backend_wrapper.c
building 'u1db.tests.c_backend_wrapper' extension
creating build
creating build/temp.linux-x86_64-2.7-pydebug
creating build/temp.linux-x86_64-2.7-pydebug/u1db
creating build/temp.linux-x86_64-2.7-pydebug/u1db/tests
gcc -pthread -fno-strict-aliasing -g -O0 -Wall -Wstrict-prototypes -fPIC -Iinclude -I/mnt/tarmac/cache/u1db/trunk/include -I/usr/include/python2.7_d -c u1db/tests/c_backend_wrapper.c -o build/temp.linux-x86_64-2.7-pydebug/u1db/tests/c_backend_wrapper.o
gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro build/temp.linux-x86_64-2.7-pydebug/u1db/tests/c_backend_wrapper.o -Lsrc -lu1db -lsqlite3 -loauth -lcurl -ljson -o /mnt/tarmac/cache/u1db/trunk/u1db/tests/c_backend_wrapper_d.so
[100%] Built target build-debug
Scanning dependencies of target check-valgrind
Tests running...
======================================================================
FAIL: u1db.tests.test_sync.DatabaseSyncTests.test_sync_tracks_db_generation_of_other(c,csync)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/mnt/tarmac/cache/u1db/trunk/u1db/tests/test_sync.py", line 506, in test_sync_tracks_db_generation_of_other
self.assertEqual(0, self.sync(self.db1, self.db2))
MismatchError: 0 != 4

Ran 1503 tests in 197.984s
FAILED (failures=1)

[197040 refs]
==25811== Memcheck, a memory error detector
==25811== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==25811== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==25811== Command: python-dbg -m testtools.run discover
==25811==
==25811== Conditional jump or move depends on uninitialised value(s)
==25811== at 0x465DE7: PyInt_FromLong (intobject.c:91)
==25811== by 0x97649BD: __pyx_pf_4u1db_5tests_17c_backend_wrapper_6sync_db_to_target (c_backend_wrapper.c:16525)
==25811== by 0x97645B5: __pyx_pw_4u1db_5tests_17c_backend_wrapper_7sync_db_to_target (c_backend_wrapper.c:16418)
==25811== by 0x487E17: PyCFunction_Call (methodobject.c:85)
==25811== by 0x52742B: call_function (ceval.c:4021)
==25811== by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811== by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811== by 0x527A19: fast_function (ceval.c:4117)
==25811== by 0x527602: call_function (ceval.c:4042)
==25811== by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811== by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811== by 0x527A19: fast_function (ceval.c:4117)
==25811==
==25811== Conditional jump or move depends on uninitialised value(s)
==25811== at 0x465DF1: PyInt_FromLong (intobject.c:91)
==25811== by 0x97649BD: __pyx_pf_4u1db_5tests_17c_backend_wrapper_6sync_db_to_target (c_backend_wrapper.c:16525)
==25811== by 0x97645B5: __pyx_pw_4u1db_5tests_17c_backend_wrapper_7sync_db_to_target (c_backend_wrapper.c:16418)
==25811== by 0x487E17: PyCFunction_Call (methodobject.c:85)
==25811== by 0x52742B: call_function (ceval.c:4021)
==25811== by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811== by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811== by 0x527A19: fast_function (ceval.c:4117)
==25811== by 0x527602: call_function (ceval.c:4042)
==25811== by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811== by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811== by 0x527A19: fast_function (ceval.c:4117)
==25811==
==25811== Use of uninitialised value of size 8
==25811== at 0x465DFB: PyInt_FromLong (intobject.c:92)
==25811== by 0x97649BD: __pyx_pf_4u1db_5tests_17c_backend_wrapper_6sync_db_to_target (c_backend_wrapper.c:16525)
==25811== by 0x97645B5: __pyx_pw_4u1db_5tests_17c_backend_wrapper_7sync_db_to_target (c_backend_wrapper.c:16418)
==25811== by 0x487E17: PyCFunction_Call (methodobject.c:85)
==25811== by 0x52742B: call_function (ceval.c:4021)
==25811== by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811== by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811== by 0x527A19: fast_function (ceval.c:4117)
==25811== by 0x527602: call_function (ceval.c:4042)
==25811== by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811== by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811== by 0x527A19: fast_function (ceval.c:4117)
==25811==
[167490 refs]
==25811==
==25811== HEAP SUMMARY:
==25811== in use at exit: 27,055,584 bytes in 10,299 blocks
==25811== total heap usage: 2,490,620 allocs, 2,480,321 frees, 1,032,955,036 bytes allocated
==25811==
==25811== LEAK SUMMARY:
==25811== definitely lost: 72 bytes in 1 blocks
==25811== indirectly lost: 0 bytes in 0 blocks
==25811== possibly lost: 4,818,411 bytes in 6,326 blocks
==25811== still reachable: 22,237,101 bytes in 3,972 blocks
==25811== suppressed: 0 bytes in 0 blocks
==25811== Rerun with --leak-check=full to see details of leaked memory
==25811==
==25811== For counts of detected and suppressed errors, rerun with: -v
==25811== Use --track-origins=yes to see where uninitialised values come from
==25811== ERROR SUMMARY: 5 errors from 3 contexts (suppressed: 91676 from 103)
make[3]: *** [CMakeFiles/check-valgrind] Error 1
make[2]: *** [CMakeFiles/check-valgrind.dir/all] Error 2
make[1]: *** [CMakeFiles/check-valgrind.dir/rule] Error 2
make: *** [check-valgrind] Error 2

The attempt to merge lp:~thisfred/u1db/fix-local-gen-before-sync into lp:u1db failed. Below is the output from the failed tests.

-- The C compiler identification is GNU 4.7.1
-- The CXX compiler identification is GNU 4.7.1
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found Cython: /usr/bin/cython  
-- Found CURL: /usr/lib/x86_64-linux-gnu/libcurl.so (found version "7.26.0") 
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.26") 
-- checking for module 'oauth'
--   found oauth, version 0.9.7
-- Found OAuth: /usr/lib/x86_64-linux-gnu/liboauth.so  
-- checking for module 'json'
--   found json, version 0.9
-- Found JSON: /usr/lib/x86_64-linux-gnu/libjson.so  
-- checking for module 'sqlite3'
--   found sqlite3, version 3.7.13
-- Found Sqlite3: /usr/lib/x86_64-linux-gnu/libsqlite3.so  
-- Configuring done
-- Generating done
-- Build files have been written to: /mnt/tarmac/cache/u1db/trunk
[ 11%] Generating u1db_schema.c
Scanning dependencies of target u1db
[ 22%] Building C object src/CMakeFiles/u1db.dir/mkstemp_compat.c.o
[ 33%] Building C object src/CMakeFiles/u1db.dir/u1db.c.o
[ 44%] Building C object src/CMakeFiles/u1db.dir/u1db_http_sync_target.c.o
[ 55%] Building C object src/CMakeFiles/u1db.dir/u1db_query.c.o
[ 66%] Building C object src/CMakeFiles/u1db.dir/u1db_sync_target.c.o
[ 77%] Building C object src/CMakeFiles/u1db.dir/u1db_uuid.c.o
[ 88%] Building C object src/CMakeFiles/u1db.dir/u1db_vectorclock.c.o
[100%] Building C object src/CMakeFiles/u1db.dir/u1db_schema.c.o
Linking C static library libu1db.a
[100%] Built target u1db
Scanning dependencies of target ReplicatePythonSourceTree
[100%] Built target ReplicatePythonSourceTree
Scanning dependencies of target build-debug
running build_ext
cythoning u1db/tests/c_backend_wrapper.pyx to u1db/tests/c_backend_wrapper.c
building 'u1db.tests.c_backend_wrapper' extension
creating build
creating build/temp.linux-x86_64-2.7-pydebug
creating build/temp.linux-x86_64-2.7-pydebug/u1db
creating build/temp.linux-x86_64-2.7-pydebug/u1db/tests
gcc -pthread -fno-strict-aliasing -g -O0 -Wall -Wstrict-prototypes -fPIC -Iinclude -I/mnt/tarmac/cache/u1db/trunk/include -I/usr/include/python2.7_d -c u1db/tests/c_backend_wrapper.c -o build/temp.linux-x86_64-2.7-pydebug/u1db/tests/c_backend_wrapper.o
gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro build/temp.linux-x86_64-2.7-pydebug/u1db/tests/c_backend_wrapper.o -Lsrc -lu1db -lsqlite3 -loauth -lcurl -ljson -o /mnt/tarmac/cache/u1db/trunk/u1db/tests/c_backend_wrapper_d.so
[100%] Built target build-debug
Scanning dependencies of target check-valgrind
Tests running...
======================================================================
FAIL: u1db.tests.test_sync.DatabaseSyncTests.test_sync_tracks_db_generation_of_other(c,csync)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/tarmac/cache/u1db/trunk/u1db/tests/test_sync.py", line 506, in test_sync_tracks_db_generation_of_other
    self.assertEqual(0, self.sync(self.db1, self.db2))
MismatchError: 0 != 4

Ran 1503 tests in 197.984s
FAILED (failures=1)

[197040 refs]
==25811== Memcheck, a memory error detector
==25811== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==25811== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==25811== Command: python-dbg -m testtools.run discover
==25811== 
==25811== Conditional jump or move depends on uninitialised value(s)
==25811==    at 0x465DE7: PyInt_FromLong (intobject.c:91)
==25811==    by 0x97649BD: __pyx_pf_4u1db_5tests_17c_backend_wrapper_6sync_db_to_target (c_backend_wrapper.c:16525)
==25811==    by 0x97645B5: __pyx_pw_4u1db_5tests_17c_backend_wrapper_7sync_db_to_target (c_backend_wrapper.c:16418)
==25811==    by 0x487E17: PyCFunction_Call (methodobject.c:85)
==25811==    by 0x52742B: call_function (ceval.c:4021)
==25811==    by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811==    by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811==    by 0x527A19: fast_function (ceval.c:4117)
==25811==    by 0x527602: call_function (ceval.c:4042)
==25811==    by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811==    by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811==    by 0x527A19: fast_function (ceval.c:4117)
==25811== 
==25811== Conditional jump or move depends on uninitialised value(s)
==25811==    at 0x465DF1: PyInt_FromLong (intobject.c:91)
==25811==    by 0x97649BD: __pyx_pf_4u1db_5tests_17c_backend_wrapper_6sync_db_to_target (c_backend_wrapper.c:16525)
==25811==    by 0x97645B5: __pyx_pw_4u1db_5tests_17c_backend_wrapper_7sync_db_to_target (c_backend_wrapper.c:16418)
==25811==    by 0x487E17: PyCFunction_Call (methodobject.c:85)
==25811==    by 0x52742B: call_function (ceval.c:4021)
==25811==    by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811==    by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811==    by 0x527A19: fast_function (ceval.c:4117)
==25811==    by 0x527602: call_function (ceval.c:4042)
==25811==    by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811==    by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811==    by 0x527A19: fast_function (ceval.c:4117)
==25811== 
==25811== Use of uninitialised value of size 8
==25811==    at 0x465DFB: PyInt_FromLong (intobject.c:92)
==25811==    by 0x97649BD: __pyx_pf_4u1db_5tests_17c_backend_wrapper_6sync_db_to_target (c_backend_wrapper.c:16525)
==25811==    by 0x97645B5: __pyx_pw_4u1db_5tests_17c_backend_wrapper_7sync_db_to_target (c_backend_wrapper.c:16418)
==25811==    by 0x487E17: PyCFunction_Call (methodobject.c:85)
==25811==    by 0x52742B: call_function (ceval.c:4021)
==25811==    by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811==    by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811==    by 0x527A19: fast_function (ceval.c:4117)
==25811==    by 0x527602: call_function (ceval.c:4042)
==25811==    by 0x522216: PyEval_EvalFrameEx (ceval.c:2666)
==25811==    by 0x524C04: PyEval_EvalCodeEx (ceval.c:3253)
==25811==    by 0x527A19: fast_function (ceval.c:4117)
==25811== 
[167490 refs]
==25811== 
==25811== HEAP SUMMARY:
==25811==     in use at exit: 27,055,584 bytes in 10,299 blocks
==25811==   total heap usage: 2,490,620 allocs, 2,480,321 frees, 1,032,955,036 bytes allocated
==25811== 
==25811== LEAK SUMMARY:
==25811==    definitely lost: 72 bytes in 1 blocks
==25811==    indirectly lost: 0 bytes in 0 blocks
==25811==      possibly lost: 4,818,411 bytes in 6,326 blocks
==25811==    still reachable: 22,237,101 bytes in 3,972 blocks
==25811==         suppressed: 0 bytes in 0 blocks
==25811== Rerun with --leak-check=full to see details of leaked memory
==25811== 
==25811== For counts of detected and suppressed errors, rerun with: -v
==25811== Use --track-origins=yes to see where uninitialised values come from
==25811== ERROR SUMMARY: 5 errors from 3 contexts (suppressed: 91676 from 103)
make[3]: *** [CMakeFiles/check-valgrind] Error 1
make[2]: *** [CMakeFiles/check-valgrind.dir/all] Error 2
make[1]: *** [CMakeFiles/check-valgrind.dir/rule] Error 2
make: *** [check-valgrind] Error 2

« Back to merge proposal