Code review comment for ~thibf/uvtool:thibf/uvt-kvm_wait_system_booting

Revision history for this message
Robie Basak (racb) wrote :

> I think in this case we can "just" rely on the exit code of ssh.

If the remote wait script fails, then we should exit immediately rather than retry. So I think this should be gated on the exit value being 255 only. Any other exit value should result in an immediate failure (eg. by passing CalledProcessError through). Sorry to ask for further changes - I thought this is what I specified above?

> I added an explicit error message for the timeout. Should we print the exception thrown by the sub-command ? Might help further debugging but reduce readability.

This looks good, thanks. I don't think it's worth going into that right now. I'll add one minor comment inline so that this might be more easily enhanced later.

review: Needs Fixing

« Back to merge proposal