Code review comment for lp:~therve/storm/resultset-select-copy

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Looks good to me as well. Just one detail if you don't mind:

[1]

Can you please add some docs right above the copying, pointing out the entanglement between the few pieces which create the bug, and which require the copying to happen? This will be very valuable in a week, when we don't recall what the heck this is about anymore. :-)

review: Approve

« Back to merge proposal