Code review comment for lp:~therve/landscape-client/package-reporter-result

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Great, +1!

[1]

+ "out": out,

The output could be biggish, not sure that we really want to include it in the message, also it's not clear what use the server would make of it. Maybe it could be skipped initially (till we find a use case)? IIRC adding a field to a message shouldn't be painful. This is not blocking if you think that the extra payload is negligible.

review: Approve

« Back to merge proposal