Merge lp:~therve/landscape-client/natty-packaging into lp:~landscape/landscape-client/trunk

Proposed by Thomas Herve
Status: Merged
Merged at revision: 303
Proposed branch: lp:~therve/landscape-client/natty-packaging
Merge into: lp:~landscape/landscape-client/trunk
Diff against target: 76 lines (+19/-22)
2 files modified
debian/control (+1/-1)
debian/rules (+18/-21)
To merge this branch: bzr merge lp:~therve/landscape-client/natty-packaging
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Free Ekanayaka (community) Approve
Review via email: mp+45930@code.launchpad.net

Description of the change

The branch builds for 2.7 on natty, using dh_python2. It also tries to only refer to old versions instead of listing every one of them.

To post a comment you must log in.
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Looks good. +1!

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

I will still try the build on all distros, but don't want to block on that.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Oh, forgot to formally approve it

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Formal approval that I forgot at the time.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2010-08-02 15:45:12 +0000
3+++ debian/control 2011-01-11 23:17:26 +0000
4@@ -5,7 +5,7 @@
5 XSBC-Original-Maintainer: Landscape Team <landscape-team@canonical.com>
6 Build-Depends: debhelper (>= 5), po-debconf, python-dev, python-central | python-support, lsb-release, gawk, python-twisted-core
7 Standards-Version: 3.8.0
8-XS-Python-Version: >= 2.4, << 2.7
9+XS-Python-Version: >= 2.4, << 2.8
10
11 Package: landscape-common
12 Architecture: any
13
14=== modified file 'debian/rules'
15--- debian/rules 2010-06-28 16:07:01 +0000
16+++ debian/rules 2011-01-11 23:17:26 +0000
17@@ -4,6 +4,9 @@
18 ifneq ($(dist_release),dapper)
19 use_pycentral = yes
20 endif
21+ifeq (,$(filter $(dist_release), dapper hardy karmic lucid maverick))
22+ use_dhpython2 = yes
23+endif
24
25 -include /usr/share/python/python.mk
26 ifeq (,$(py_sitename))
27@@ -86,34 +89,28 @@
28 echo "extra:Depends=python-smartpm (>= 1.1.1~bzr20081010-0ubuntu1.8.04.1), python2.4-dbus" >> $(landscape_common_substvars)
29 echo "extra:Depends=python2.4-pycurl" >> $(landscape_client_substvars)
30 endif
31-ifneq (,$(findstring $(dist_release),"intrepid"))
32- # We want the SRU-ed smart 1.1.1 on intrepid
33- echo "extra:Depends=update-motd, python-smartpm (>= 1.1.1~bzr20081010-0ubuntu1.8.10.0), python2.5-dbus" >> $(landscape_common_substvars)
34- echo "extra:Depends=python2.5-pycurl" >> $(landscape_client_substvars)
35-endif
36-ifneq (,$(findstring $(dist_release),"jaunty"))
37- # We want update-motd on jaunty, and the SRU-ed smart 1.2
38- echo "extra:Depends=update-motd, python-smartpm (>= 1.2-0ubuntu1.9.04.1), python2.6-dbus" >> $(landscape_common_substvars)
39- echo "extra:Depends=python2.6-pycurl" >> $(landscape_client_substvars)
40-endif
41-ifneq (,$(findstring $(dist_release),"karmic lucid maverick"))
42+ifeq (,$(filter $(dist_release),dapper hardy))
43 # We want libpam-modules in karmic, and smart 1.2
44- echo "extra:Depends=libpam-modules (>= 1.0.1-9ubuntu3), python-smartpm (>= 1.2-4), python2.6-dbus" >> $(landscape_common_substvars)
45- echo "extra:Depends=python2.6-pycurl" >> $(landscape_client_substvars)
46+ echo "extra:Depends=libpam-modules (>= 1.0.1-9ubuntu3), python-smartpm (>= 1.2-4), python-dbus" >> $(landscape_common_substvars)
47+ echo "extra:Depends=python-pycurl" >> $(landscape_client_substvars)
48 endif
49-ifneq (,$(findstring $(dist_release),"lucid maverick"))
50+ifeq (,$(filter $(dist_release),dapper hardy karmic))
51 # The python-image-store-proxy package is needed for the eucalyptus plugin
52 echo "extra:Suggests=python-image-store-proxy" >> $(landscape_common_substvars)
53 endif
54
55-ifeq ($(use_pycentral),yes)
56- ifneq (,$(py_setup_install_args))
57- DH_PYCENTRAL=include-links dh_pycentral
58- else
59- DH_PYCENTRAL=nomove dh_pycentral
60- endif
61+ifeq ($(use_dhpython2),yes)
62+ dh_python2 --no-guessing-versions
63 else
64- dh_python
65+ ifeq ($(use_pycentral),yes)
66+ ifneq (,$(py_setup_install_args))
67+ DH_PYCENTRAL=include-links dh_pycentral
68+ else
69+ DH_PYCENTRAL=nomove dh_pycentral
70+ endif
71+ else
72+ dh_python
73+ endif
74 endif
75 dh_installdeb
76 dh_gencontrol

Subscribers

People subscribed via source and target branches

to all changes: